From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Daniel Wagner <dwagner@suse.de>
Cc: Jakub Kicinski <jakub.kicinski@netronome.com>,
UNGLinuxDriver@microchip.com, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rt-users@vger.kernel.org,
Woojung Huh <woojung.huh@microchip.com>,
Marc Zyngier <maz@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Stefan Wahren <wahrenst@gmx.net>,
Jisheng Zhang <Jisheng.Zhang@synaptics.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] net: usb: lan78xx: Use phy_mac_interrupt() for interrupt handling
Date: Thu, 24 Oct 2019 12:43:17 +0200 [thread overview]
Message-ID: <20191024104317.32bp32krrjmfb36p@linutronix.de> (raw)
In-Reply-To: <20191023080640.zcw2f2v7fpanoewm@beryllium.lan>
On 2019-10-23 10:06:40 [+0200], Daniel Wagner wrote:
> Sebastian suggested to try this here:
>
> --- a/drivers/net/usb/lan78xx.c
> +++ b/drivers/net/usb/lan78xx.c
> @@ -1264,8 +1264,11 @@ static void lan78xx_status(struct lan78xx_net *dev, struct urb *urb)
> netif_dbg(dev, link, dev->net, "PHY INTR: 0x%08x\n", intdata);
> lan78xx_defer_kevent(dev, EVENT_LINK_RESET);
>
> - if (dev->domain_data.phyirq > 0)
> + if (dev->domain_data.phyirq > 0) {
> + local_irq_disable();
> generic_handle_irq(dev->domain_data.phyirq);
> + local_irq_enable();
> + }
> } else
> netdev_warn(dev->net,
> "unexpected interrupt: 0x%08x\n", intdata);
This should should be applied as a regression fix introduced by commit
ed194d1367698 ("usb: core: remove local_irq_save() around ->complete() handler")
> While this gets rid of the warning, the networking interface is not
> really stable:
>
> [ 43.999628] nfs: server 192.168.19.2 not responding, still trying
> [ 43.999633] nfs: server 192.168.19.2 not responding, still trying
> [ 43.999649] nfs: server 192.168.19.2 not responding, still trying
> [ 43.999674] nfs: server 192.168.19.2 not responding, still trying
> [ 43.999678] nfs: server 192.168.19.2 not responding, still trying
> [ 44.006712] nfs: server 192.168.19.2 OK
> [ 44.018443] nfs: server 192.168.19.2 OK
> [ 44.024765] nfs: server 192.168.19.2 OK
> [ 44.025361] nfs: server 192.168.19.2 OK
> [ 44.025420] nfs: server 192.168.19.2 OK
> [ 256.991659] nfs: server 192.168.19.2 not responding, still trying
> [ 256.991664] nfs: server 192.168.19.2 not responding, still trying
> [ 256.991669] nfs: server 192.168.19.2 not responding, still trying
> [ 256.991685] nfs: server 192.168.19.2 not responding, still trying
> [ 256.991713] nfs: server 192.168.19.2 not responding, still trying
> [ 256.998797] nfs: server 192.168.19.2 OK
> [ 256.999745] nfs: server 192.168.19.2 OK
> [ 256.999828] nfs: server 192.168.19.2 OK
> [ 257.000438] nfs: server 192.168.19.2 OK
> [ 257.004784] nfs: server 192.168.19.2 OK
Since this does not improve the situation as a whole it might be best to
remove the code as suggested by Daniel.
Sebastian
next prev parent reply other threads:[~2019-10-24 10:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 8:28 [PATCH] net: usb: lan78xx: Use phy_mac_interrupt() for interrupt handling Daniel Wagner
2019-10-18 11:02 ` Marc Zyngier
2019-10-18 13:15 ` Sebastian Andrzej Siewior
2019-10-22 17:17 ` Jakub Kicinski
2019-10-22 17:34 ` Marc Zyngier
2019-10-23 7:47 ` Daniel Wagner
2019-10-23 8:06 ` Daniel Wagner
2019-10-24 10:43 ` Sebastian Andrzej Siewior [this message]
2019-10-24 11:06 ` Daniel Wagner
2019-10-24 14:12 ` Daniel Wagner
2019-10-24 17:25 ` Stefan Wahren
2019-10-25 7:33 ` Daniel Wagner
2019-10-24 21:57 ` David Miller
2019-10-25 7:36 ` Sebastian Andrzej Siewior
2019-10-25 6:00 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024104317.32bp32krrjmfb36p@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=Jisheng.Zhang@synaptics.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=dwagner@suse.de \
--cc=jakub.kicinski@netronome.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maz@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=wahrenst@gmx.net \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox