From: Matt Fleming <matt@codeblueprint.co.uk>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org,
Daniel Wagner <wagi@monom.org>
Subject: Re: [PATCH RT] mm/memcontrol: Move misplaced local_unlock_irqrestore()
Date: Tue, 4 Feb 2020 09:35:19 +0000 [thread overview]
Message-ID: <20200204093519.GC4303@codeblueprint.co.uk> (raw)
In-Reply-To: <20200203181746.htlca2aynoqidm3o@linutronix.de>
On Mon, 03 Feb, at 07:17:46PM, Sebastian Andrzej Siewior wrote:
> On 2020-01-26 21:19:45 [+0000], Matt Fleming wrote:
> > There's no need to leave interrupts disabled when calling css_put_many().
>
> For RT the interrupts are never actually disabled and for !RT they are
> disabled with or without the change.
> The comment about the disable function mentions just the counters and
> css_put_many()'s callback just invokes a worker so it is probably save
> to move the function as suggested.
>
> May I ask how on earth you managed to open that file on a Sunday
> evening?
We're carrying it in some of our older SUSE RT kernels and I'd really
like to get it upstream or sent to /dev/null ;)
next prev parent reply other threads:[~2020-02-04 9:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-26 21:19 [PATCH RT] mm/memcontrol: Move misplaced local_unlock_irqrestore() Matt Fleming
2020-02-03 18:17 ` Sebastian Andrzej Siewior
2020-02-04 9:35 ` Matt Fleming [this message]
2020-02-04 11:10 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200204093519.GC4303@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=wagi@monom.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).