From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EC4BC7619F for ; Mon, 17 Feb 2020 09:33:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F0ADF2070B for ; Mon, 17 Feb 2020 09:33:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581932029; bh=Hva1VYTaIHTinRbcAfWrHrtqtw1QHqKCZCklauDBsBU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=Eo5qN1saHKseN8ZTN4A+rlXevW8eRoUeVyWM8ypCcxEXoEByHE159p5gSovtxddus S3R7r9wgodTvzYuRmEFzt6uQBaqlXNxxiSAsYjMWdGda8eQHCR64NKwJlL1OfWgjX3 3RQ+qG01XFe7bqo+/426Fg4yXbwZJ4NFoRmSO6w4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728873AbgBQJdp (ORCPT ); Mon, 17 Feb 2020 04:33:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:36676 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728698AbgBQJdo (ORCPT ); Mon, 17 Feb 2020 04:33:44 -0500 Received: from devnote2 (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 516AF20679; Mon, 17 Feb 2020 09:33:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581932024; bh=Hva1VYTaIHTinRbcAfWrHrtqtw1QHqKCZCklauDBsBU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KVCfI1p92V+a5wkQ6qbcBjhOl+fBTlbHuw5LKN+Wi6VfGjdJoZGNZWtPu6ZlEHgdQ L/6c2PFz0aqK0k7FrFbBcdIwRogvEZyMbGE/CaisaRZXyyQvqi1hGdzRLYCzKfJL93 mzMz9gu/1RgTFuU16LAFV3pwjaAZBvPGqzbyrGSw= Date: Mon, 17 Feb 2020 18:33:40 +0900 From: Masami Hiramatsu To: Masami Hiramatsu Cc: Steven Rostedt , Tom Zanussi , artem.bityutskiy@linux.intel.com, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org Subject: Re: [PATCH] tracing: Skip software disabled event at __synth_event_trace_end() Message-Id: <20200217183340.121fed47e680584c4ca6dd93@kernel.org> In-Reply-To: <158148685911.20407.3538292497442671878.stgit@devnote2> References: <158148685911.20407.3538292497442671878.stgit@devnote2> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-rt-users-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rt-users@vger.kernel.org On Wed, 12 Feb 2020 14:54:19 +0900 Masami Hiramatsu wrote: > When the synthetic event is software disabled, > __synth_event_trace_start() does not allocate an event buffer. > In this case __synth_event_trace_end() also should not commit > the buffer. > > Check the trace_state->disabled at __synth_event_trace_end() > and if it is disabled, skip it. > > Signed-off-by: Masami Hiramatsu > --- > kernel/trace/trace_events_hist.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c > index 483b3fd1094f..781e4b55e117 100644 > --- a/kernel/trace/trace_events_hist.c > +++ b/kernel/trace/trace_events_hist.c > @@ -1847,6 +1847,9 @@ __synth_event_trace_start(struct trace_event_file *file, > static inline void > __synth_event_trace_end(struct synth_event_trace_state *trace_state) > { > + if (trace_state->disabled) > + return; > + Aah, I assumed that trace_state should be initialized with 0, but in really, it could be just allocated on the stack. We has to set trace_state->disabled = false in __synth_event_trace_start(). Thank you, > trace_event_buffer_commit(&trace_state->fbuffer); > > ring_buffer_nest_end(trace_state->buffer); > -- Masami Hiramatsu