From: "Luis Claudio R. Goncalves" <lclaudio@uudg.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-rt-users <linux-rt-users@vger.kernel.org>
Subject: Re: [PATCH v5.6.4-rt3] rfcomm/bluetooth: avoid disabling interrupts on RT
Date: Wed, 27 May 2020 14:40:16 -0300 [thread overview]
Message-ID: <20200527174016.GZ5108@uudg.org> (raw)
In-Reply-To: <20200527094858.qqbctvdgr6bvjfqn@linutronix.de>
On Wed, May 27, 2020 at 11:48:58AM +0200, Sebastian Andrzej Siewior wrote:
> On 2020-04-23 16:31:55 [-0300], Luis Claudio R. Goncalves wrote:
> …
> > Replacing local_irq_save()/bh_lock_sock() by spin_lock_bh() keeps the semantics
> > and does the right thing under PREEMPT_RT.
>
> Nope. The irq-off was introduced in commit
> fad003b6c8e3d ("Bluetooth: Fix inconsistent lock state with RFCOMM")
>
> It doesn't look right. Could you please revert that commit and check if
> lockdep still complains?
Thanks, Sebastian! I built a kernel with commit fad003b6c8e3d reverted and
the lockdep complaints are gone.
Luis
prev parent reply other threads:[~2020-05-27 17:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 19:31 [PATCH v5.6.4-rt3] rfcomm/bluetooth: avoid disabling interrupts on RT Luis Claudio R. Goncalves
2020-05-27 9:48 ` Sebastian Andrzej Siewior
2020-05-27 17:40 ` Luis Claudio R. Goncalves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527174016.GZ5108@uudg.org \
--to=lclaudio@uudg.org \
--cc=bigeasy@linutronix.de \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).