From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A24CC433E1 for ; Fri, 29 May 2020 14:53:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 73B0B2077D for ; Fri, 29 May 2020 14:53:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726849AbgE2OxY (ORCPT ); Fri, 29 May 2020 10:53:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:34354 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725901AbgE2OxX (ORCPT ); Fri, 29 May 2020 10:53:23 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EF52C2077D; Fri, 29 May 2020 14:53:22 +0000 (UTC) Date: Fri, 29 May 2020 10:53:21 -0400 From: Steven Rostedt To: Masami Hiramatsu Cc: Tom Zanussi , skhan@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org Subject: Re: [PATCH v2 2/2] selftests/ftrace: Distinguish between hist and synthetic event checks Message-ID: <20200529105321.0bcf3219@oasis.local.home> In-Reply-To: <20200529233845.25d975c6b23d62da1dfb75cb@kernel.org> References: <20200529233845.25d975c6b23d62da1dfb75cb@kernel.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-rt-users-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rt-users@vger.kernel.org On Fri, 29 May 2020 23:38:45 +0900 Masami Hiramatsu wrote: > Hi Tom, > > On Thu, 28 May 2020 14:32:38 -0500 > Tom Zanussi wrote: > > > With synthetic events now a separate config item as a result of > > 'tracing: Move synthetic events to a separate file', tests that use > > both need to explicitly check for hist trigger support rather than > > relying on hist triggers to pull in synthetic events. > > > > Add an additional hist trigger check to all the trigger tests that now > > require it, otherwise they'll fail if synthetic events but not hist > > triggers are enabled. > > OK, this looks good to me. And if you don't want to repeat it, > you can also put the check function into the test.d/functions. > > Acked-by: Masami Hiramatsu Thanks Tom and Masami. I'm running tests on these now. -- Steve