* [5.9.1-rt20] affine_move_task does not always release rq lock
@ 2020-11-06 20:39 Joe Korty
2020-11-09 8:59 ` Peter Zijlstra
0 siblings, 1 reply; 3+ messages in thread
From: Joe Korty @ 2020-11-06 20:39 UTC (permalink / raw)
To: Peter Zijlstra; +Cc: linux-rt-users
FYI. There is one path through affine_move_task() which
does not release the rq lock. This appears to be in error.
* Either way, we really should have a @pending here.
*/
if (WARN_ON_ONCE(!pending))
return -EINVAL;
Regards,
Joe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [5.9.1-rt20] affine_move_task does not always release rq lock
2020-11-06 20:39 [5.9.1-rt20] affine_move_task does not always release rq lock Joe Korty
@ 2020-11-09 8:59 ` Peter Zijlstra
2020-11-09 13:01 ` Joe Korty
0 siblings, 1 reply; 3+ messages in thread
From: Peter Zijlstra @ 2020-11-09 8:59 UTC (permalink / raw)
To: Joe Korty; +Cc: linux-rt-users
On Fri, Nov 06, 2020 at 03:39:21PM -0500, Joe Korty wrote:
> FYI. There is one path through affine_move_task() which
> does not release the rq lock. This appears to be in error.
>
> * Either way, we really should have a @pending here.
> */
> if (WARN_ON_ONCE(!pending))
> return -EINVAL;
Indeed so. I'm assuming you didn't actually hit the warning but found
this through inspection?
Anyway, let me go ammend this. Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [5.9.1-rt20] affine_move_task does not always release rq lock
2020-11-09 8:59 ` Peter Zijlstra
@ 2020-11-09 13:01 ` Joe Korty
0 siblings, 0 replies; 3+ messages in thread
From: Joe Korty @ 2020-11-09 13:01 UTC (permalink / raw)
To: Peter Zijlstra; +Cc: linux-rt-users
On Mon, Nov 09, 2020 at 09:59:30AM +0100, Peter Zijlstra wrote:
> On Fri, Nov 06, 2020 at 03:39:21PM -0500, Joe Korty wrote:
> > FYI. There is one path through affine_move_task() which
> > does not release the rq lock. This appears to be in error.
> >
> > * Either way, we really should have a @pending here.
> > */
> > if (WARN_ON_ONCE(!pending))
> > return -EINVAL;
>
> Indeed so. I'm assuming you didn't actually hit the warning but found
> this through inspection?
That is correct...
> Anyway, let me go ammend this. Thanks!
Yer welcome!
Joe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-09 13:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-06 20:39 [5.9.1-rt20] affine_move_task does not always release rq lock Joe Korty
2020-11-09 8:59 ` Peter Zijlstra
2020-11-09 13:01 ` Joe Korty
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox