From: Steven Rostedt <rostedt@goodmis.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
linux-rt-users <linux-rt-users@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Carsten Emde <C.Emde@osadl.org>, John Kacur <jkacur@redhat.com>,
Daniel Wagner <wagi@monom.org>, Tom Zanussi <zanussi@kernel.org>,
"Srivatsa S. Bhat" <srivatsa@csail.mit.edu>
Subject: Re: [PATCH RT 2/6] tcp: Remove superfluous BH-disable around listening_hash
Date: Mon, 9 Nov 2020 12:01:06 -0500 [thread overview]
Message-ID: <20201109120106.4fe828b4@oasis.local.home> (raw)
In-Reply-To: <20201109092231.3t2pawkvv7dxasfs@linutronix.de>
On Mon, 9 Nov 2020 10:22:31 +0100
Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> On 2020-11-06 21:06:38 [-0500], Steven Rostedt wrote:
> > 5.4.74-rt42-rc1 stable review patch.
> > If anyone has any objections, please let me know.
>
> Please drop that one. Lockep complains on RT with newer softirq code.
> Older RT and mainline does not complain here unless it observes
> inet_listen_hashbucket::lock in serving-softirq context (which is not
> the case).
>
Note, I took this because it mentioned:
"Commit
9652dc2eb9e40 ("tcp: relax listening_hash operations")
removed the need to disable bottom half while acquiring
listening_hash.lock. There are still two callers left which disable
bottom half before the lock is acquired."
And that commit was added in 4.10.
I will remove it and release a rc2.
Thanks!
-- Steve
next prev parent reply other threads:[~2020-11-09 17:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 2:06 [PATCH RT 0/6] Linux 5.4.74-rt42-rc1 Steven Rostedt
2020-11-07 2:06 ` [PATCH RT 1/6] net: Properly annotate the try-lock for the seqlock Steven Rostedt
2020-11-07 2:06 ` [PATCH RT 2/6] tcp: Remove superfluous BH-disable around listening_hash Steven Rostedt
2020-11-09 9:22 ` Sebastian Andrzej Siewior
2020-11-09 17:01 ` Steven Rostedt [this message]
2020-11-09 17:35 ` Sebastian Andrzej Siewior
2020-11-07 2:06 ` [PATCH RT 3/6] mm/memcontrol: Disable preemption in __mod_memcg_lruvec_state() Steven Rostedt
2020-11-07 2:06 ` [PATCH RT 4/6] ptrace: fix ptrace_unfreeze_traced() race with rt-lock Steven Rostedt
2020-11-07 2:06 ` [PATCH RT 5/6] timers: Dont block on ->expiry_lock for TIMER_IRQSAFE Steven Rostedt
2020-11-07 2:06 ` [PATCH RT 6/6] Linux 5.4.74-rt42-rc1 Steven Rostedt
2020-11-09 9:27 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109120106.4fe828b4@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=C.Emde@osadl.org \
--cc=bigeasy@linutronix.de \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=srivatsa@csail.mit.edu \
--cc=tglx@linutronix.de \
--cc=wagi@monom.org \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox