From: Joe Korty <joe.korty@concurrent-rt.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-rt-users@vger.kernel.org
Subject: Re: [5.9.1-rt20] affine_move_task does not always release rq lock
Date: Mon, 9 Nov 2020 08:01:41 -0500 [thread overview]
Message-ID: <20201109130141.GA7684@zipoli.concurrent-rt.com> (raw)
In-Reply-To: <20201109085930.GB2594@hirez.programming.kicks-ass.net>
On Mon, Nov 09, 2020 at 09:59:30AM +0100, Peter Zijlstra wrote:
> On Fri, Nov 06, 2020 at 03:39:21PM -0500, Joe Korty wrote:
> > FYI. There is one path through affine_move_task() which
> > does not release the rq lock. This appears to be in error.
> >
> > * Either way, we really should have a @pending here.
> > */
> > if (WARN_ON_ONCE(!pending))
> > return -EINVAL;
>
> Indeed so. I'm assuming you didn't actually hit the warning but found
> this through inspection?
That is correct...
> Anyway, let me go ammend this. Thanks!
Yer welcome!
Joe
prev parent reply other threads:[~2020-11-09 13:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 20:39 [5.9.1-rt20] affine_move_task does not always release rq lock Joe Korty
2020-11-09 8:59 ` Peter Zijlstra
2020-11-09 13:01 ` Joe Korty [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109130141.GA7684@zipoli.concurrent-rt.com \
--to=joe.korty@concurrent-rt.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox