From: Daniel Wagner <dwagner@suse.de>
To: Clark Williams <williams@redhat.com>, John Kacur <jkacur@redhat.com>
Cc: linux-rt-users@vger.kernel.org, Daniel Wagner <dwagner@suse.de>
Subject: [PATCH rt-tests v1 03/23] oslat: Rename command line option --output to --json
Date: Wed, 19 May 2021 19:09:25 +0200 [thread overview]
Message-ID: <20210519170945.21941-4-dwagner@suse.de> (raw)
In-Reply-To: <20210519170945.21941-1-dwagner@suse.de>
The initial idea was to have several different output format
supported but it turns out everyone is happy with JSON, so
there is no need to add another format.
Thus let's make the command line option more specific and
rename it to --json.
Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
src/oslat/oslat.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/oslat/oslat.c b/src/oslat/oslat.c
index 37d528f0f7ff..32de951f27c0 100644
--- a/src/oslat/oslat.c
+++ b/src/oslat/oslat.c
@@ -174,7 +174,7 @@ struct global {
int quiet;
int single_preheat_thread;
int output_omit_zero_buckets;
- char outfile[MAX_PATH];
+ char jsonfile[MAX_PATH];
/* Mutable state. */
volatile enum command cmd;
@@ -560,6 +560,7 @@ static void usage(int error)
"-C, --cpu-main-thread Specify which CPU the main thread runs on. Default is cpu0.\n"
"-D, --duration Specify test duration, e.g., 60, 20m, 2H\n"
" (m/M: minutes, h/H: hours, d/D: days)\n"
+ " --json=FILENAME write final results into FILENAME, JSON formatted\n"
"-f, --rtprio Using SCHED_FIFO priority (1-99)\n"
"-m, --workload-mem Size of the memory to use for the workload (e.g., 4K, 1M).\n"
" Total memory usage will be this value multiplies 2*N,\n"
@@ -570,7 +571,6 @@ static void usage(int error)
" NOTE: please make sure the CPU frequency on all testing cores\n"
" are locked before using this parmater. If you don't know how\n"
" to lock the freq then please don't use this parameter.\n"
- " --output=FILENAME write final results into FILENAME, JSON formatted\n"
"-T, --trace-threshold Stop the test when threshold triggered (in us),\n"
" print a marker in ftrace and stop ftrace too.\n"
"-v, --version Display the version of the software.\n"
@@ -597,8 +597,8 @@ static int workload_select(char *name)
enum option_value {
OPT_BUCKETSIZE=1, OPT_CPU_LIST, OPT_CPU_MAIN_THREAD,
- OPT_DURATION, OPT_RT_PRIO, OPT_HELP, OPT_TRACE_TH,
- OPT_WORKLOAD, OPT_WORKLOAD_MEM, OPT_BIAS, OPT_OUTPUT,
+ OPT_DURATION, OPT_JSON, OPT_RT_PRIO, OPT_HELP, OPT_TRACE_TH,
+ OPT_WORKLOAD, OPT_WORKLOAD_MEM, OPT_BIAS,
OPT_QUIET, OPT_SINGLE_PREHEAT, OPT_ZERO_OMIT,
OPT_VERSION
};
@@ -613,6 +613,7 @@ static void parse_options(int argc, char *argv[])
{ "cpu-list", required_argument, NULL, OPT_CPU_LIST },
{ "cpu-main-thread", required_argument, NULL, OPT_CPU_MAIN_THREAD},
{ "duration", required_argument, NULL, OPT_DURATION },
+ { "json", required_argument, NULL, OPT_JSON },
{ "rtprio", required_argument, NULL, OPT_RT_PRIO },
{ "help", no_argument, NULL, OPT_HELP },
{ "trace-threshold", required_argument, NULL, OPT_TRACE_TH },
@@ -621,7 +622,6 @@ static void parse_options(int argc, char *argv[])
{ "bias", no_argument, NULL, OPT_BIAS },
{ "quiet", no_argument, NULL, OPT_QUIET },
{ "single-preheat", no_argument, NULL, OPT_SINGLE_PREHEAT },
- { "output", required_argument, NULL, OPT_OUTPUT },
{ "zero-omit", no_argument, NULL, OPT_ZERO_OMIT },
{ "version", no_argument, NULL, OPT_VERSION },
{ NULL, 0, NULL, 0 },
@@ -677,8 +677,8 @@ static void parse_options(int argc, char *argv[])
exit(1);
}
break;
- case OPT_OUTPUT:
- strncpy(g.outfile, optarg, strnlen(optarg, MAX_PATH-1));
+ case OPT_JSON:
+ strncpy(g.jsonfile, optarg, strnlen(optarg, MAX_PATH-1));
break;
case OPT_TRACE_TH:
case 'T':
@@ -862,8 +862,8 @@ int main(int argc, char *argv[])
write_summary(threads);
- if (strlen(g.outfile) != 0)
- rt_write_json(g.outfile, 0, write_summary_json, threads);
+ if (strlen(g.jsonfile) != 0)
+ rt_write_json(g.jsonfile, 0, write_summary_json, threads);
if (g.cpu_list) {
free(g.cpu_list);
--
2.31.1
next prev parent reply other threads:[~2021-05-19 17:09 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 17:09 [PATCH rt-tests v1 00/23] Rename --output to --json Daniel Wagner
2021-05-19 17:09 ` [PATCH rt-tests v1 01/23] cyclicdeadline: Fix JSON output format Daniel Wagner
2021-05-21 21:30 ` John Kacur
2021-05-19 17:09 ` [PATCH rt-tests v1 02/23] cyclictest: Rename command line option --output to --json Daniel Wagner
2021-05-21 21:32 ` John Kacur
2021-05-19 17:09 ` Daniel Wagner [this message]
2021-05-21 21:35 ` [PATCH rt-tests v1 03/23] oslat: " John Kacur
2021-05-19 17:09 ` [PATCH rt-tests v1 04/23] pi_stress: " Daniel Wagner
2021-05-21 21:39 ` John Kacur
2021-05-19 17:09 ` [PATCH rt-tests v1 05/23] pmqtest: " Daniel Wagner
2021-05-21 21:41 ` John Kacur
2021-05-19 17:09 ` [PATCH rt-tests v1 06/23] ptsematest: " Daniel Wagner
2021-05-21 21:45 ` John Kacur
2021-05-19 17:09 ` [PATCH rt-tests v1 07/23] rt-migrate-test: " Daniel Wagner
2021-05-21 21:47 ` John Kacur
2021-05-19 17:09 ` [PATCH rt-tests v1 08/23] cyclicdeadline: " Daniel Wagner
2021-05-21 21:49 ` John Kacur
2021-05-19 17:09 ` [PATCH rt-tests v1 09/23] signaltest: " Daniel Wagner
2021-05-21 21:51 ` John Kacur
2021-05-19 17:09 ` [PATCH rt-tests v1 10/23] sigwaittest: " Daniel Wagner
2021-05-22 3:33 ` John Kacur
2021-05-19 17:09 ` [PATCH rt-tests v1 11/23] ssdd: " Daniel Wagner
2021-05-22 3:34 ` John Kacur
2021-05-19 17:09 ` [PATCH rt-tests v1 12/23] svsematest: " Daniel Wagner
2021-05-22 3:51 ` John Kacur
2021-05-19 17:09 ` [PATCH rt-tests v1 13/23] cyclictest: Add --json to man page Daniel Wagner
2021-05-22 3:38 ` John Kacur
2021-05-19 17:09 ` [PATCH rt-tests v1 14/23] oslat: " Daniel Wagner
2021-05-22 3:39 ` John Kacur
2021-05-19 17:09 ` [PATCH rt-tests v1 15/23] pi_stress: " Daniel Wagner
2021-05-22 3:41 ` John Kacur
2021-05-19 17:09 ` [PATCH rt-tests v1 16/23] pmqtest: " Daniel Wagner
2021-05-22 3:42 ` John Kacur
2021-05-19 17:09 ` [PATCH rt-tests v1 17/23] ptsematest: " Daniel Wagner
2021-05-22 3:44 ` John Kacur
2021-05-19 17:09 ` [PATCH rt-tests v1 18/23] rt-migrate-test: " Daniel Wagner
2021-05-22 3:45 ` John Kacur
2021-05-19 17:09 ` [PATCH rt-tests v1 19/23] cyclicdeadline: " Daniel Wagner
2021-05-22 3:46 ` John Kacur
2021-05-19 17:09 ` [PATCH rt-tests v1 20/23] signaltest: " Daniel Wagner
2021-05-22 3:48 ` John Kacur
2021-05-19 17:09 ` [PATCH rt-tests v1 21/23] sigwaittest: " Daniel Wagner
2021-05-22 3:49 ` John Kacur
2021-05-19 17:09 ` [PATCH rt-tests v1 22/23] ssdd: " Daniel Wagner
2021-05-22 3:52 ` John Kacur
2021-05-19 17:09 ` [PATCH rt-tests v1 23/23] svematest: " Daniel Wagner
2021-05-22 3:54 ` John Kacur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210519170945.21941-4-dwagner@suse.de \
--to=dwagner@suse.de \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox