From: Punit Agrawal <punitagrawal@gmail.com>
To: jkacur@redhat.com
Cc: Punit Agrawal <punit1.agrawal@toshiba.co.jp>,
williams@redhat.com, linux-rt-users@vger.kernel.org
Subject: [RFC 5/7] rt-tests: cyclictest: Move signal handler to avoid function declaration
Date: Thu, 14 Oct 2021 16:12:45 +0900 [thread overview]
Message-ID: <20211014071247.4165329-6-punitagrawal@gmail.com> (raw)
In-Reply-To: <20211014071247.4165329-1-punitagrawal@gmail.com>
From: Punit Agrawal <punit1.agrawal@toshiba.co.jp>
Signed-off-by: Punit Agrawal <punit1.agrawal@toshiba.co.jp>
---
src/cyclictest/cyclictest.c | 78 ++++++++++++++++++-------------------
1 file changed, 37 insertions(+), 41 deletions(-)
diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
index 9c67a3ce3034..48a782fe167d 100644
--- a/src/cyclictest/cyclictest.c
+++ b/src/cyclictest/cyclictest.c
@@ -220,10 +220,6 @@ static char jsonfile[MAX_PATH];
static struct thread_param **parameters;
static struct thread_stat **statistics;
-static void print_stat(FILE *fp, struct thread_param *par, int index, int verbose, int quiet);
-static void rstat_print_stat(struct thread_param *par, int index, int verbose, int quiet);
-static void rstat_setup(void);
-
static int latency_target_fd = -1;
static int32_t latency_target_value = 0;
@@ -1311,43 +1307,6 @@ static int check_timer(void)
return (ts.tv_sec != 0 || ts.tv_nsec != 1);
}
-static void sighand(int sig)
-{
- if (sig == SIGUSR1) {
- int i;
- int oldquiet = quiet;
-
- quiet = 0;
- fprintf(stderr, "#---------------------------\n");
- fprintf(stderr, "# cyclictest current status:\n");
- for (i = 0; i < num_threads; i++)
- print_stat(stderr, parameters[i], i, 0, 0);
- fprintf(stderr, "#---------------------------\n");
- quiet = oldquiet;
- return;
- } else if (sig == SIGUSR2) {
- int i;
- int oldquiet = quiet;
-
- if (rstat_fd == -1) {
- fprintf(stderr, "ERROR: rstat_fd not valid\n");
- return;
- }
- rstat_ftruncate(rstat_fd, 0);
- quiet = 0;
- dprintf(rstat_fd, "#---------------------------\n");
- dprintf(rstat_fd, "# cyclictest current status:\n");
- for (i = 0; i < num_threads; i++)
- rstat_print_stat(parameters[i], i, 0, 0);
- dprintf(rstat_fd, "#---------------------------\n");
- quiet = oldquiet;
- return;
- }
- shutdown = 1;
- if (refresh_on_max)
- pthread_cond_signal(&refresh_on_max_cond);
-}
-
static void print_tids(struct thread_param *par[], int nthreads)
{
int i;
@@ -1566,6 +1525,43 @@ static void rstat_print_stat(struct thread_param *par, int index, int verbose, i
}
+static void sighand(int sig)
+{
+ if (sig == SIGUSR1) {
+ int i;
+ int oldquiet = quiet;
+
+ quiet = 0;
+ fprintf(stderr, "#---------------------------\n");
+ fprintf(stderr, "# cyclictest current status:\n");
+ for (i = 0; i < num_threads; i++)
+ print_stat(stderr, parameters[i], i, 0, 0);
+ fprintf(stderr, "#---------------------------\n");
+ quiet = oldquiet;
+ return;
+ } else if (sig == SIGUSR2) {
+ int i;
+ int oldquiet = quiet;
+
+ if (rstat_fd == -1) {
+ fprintf(stderr, "ERROR: rstat_fd not valid\n");
+ return;
+ }
+ rstat_ftruncate(rstat_fd, 0);
+ quiet = 0;
+ dprintf(rstat_fd, "#---------------------------\n");
+ dprintf(rstat_fd, "# cyclictest current status:\n");
+ for (i = 0; i < num_threads; i++)
+ rstat_print_stat(parameters[i], i, 0, 0);
+ dprintf(rstat_fd, "#---------------------------\n");
+ quiet = oldquiet;
+ return;
+ }
+ shutdown = 1;
+ if (refresh_on_max)
+ pthread_cond_signal(&refresh_on_max_cond);
+}
+
/*
* thread that creates a named fifo and hands out run stats when someone
* reads from the fifo.
--
2.32.0
next prev parent reply other threads:[~2021-10-14 7:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 7:12 [RFC 0/7] rt-tests: cyclictest: Add support to report standard deviation Punit Agrawal
2021-10-14 7:12 ` [RFC 1/7] rt-tests: cyclictest: Drop unused defines Punit Agrawal
2021-10-14 18:23 ` John Kacur
2021-11-11 20:28 ` John Kacur
2021-10-14 7:12 ` [RFC 2/7] rt-tests: cyclictest: Simplify duplicate initialization of "stop" Punit Agrawal
2021-10-14 18:29 ` John Kacur
2021-11-11 20:32 ` John Kacur
2021-10-14 7:12 ` [RFC 3/7] rt-tests: cyclictest: Drop unnecessary variable "stopped" Punit Agrawal
2021-10-14 7:12 ` [RFC 4/7] rt-tests: cyclictest: Drop unnecessary variable "bufsize" Punit Agrawal
2021-10-14 18:29 ` John Kacur
2021-10-15 8:05 ` Punit Agrawal
2021-10-15 13:07 ` John Kacur
2021-11-11 20:36 ` John Kacur
2021-10-14 7:12 ` Punit Agrawal [this message]
2021-10-14 18:31 ` [RFC 5/7] rt-tests: cyclictest: Move signal handler to avoid function declaration John Kacur
2021-10-15 8:21 ` Punit Agrawal
2021-10-14 7:12 ` [RFC 6/7] rt-tests: cyclictest: Use streaming algorithm to calculate averages Punit Agrawal
2021-10-14 7:12 ` [RFC 7/7] rt-tests: cyclictest: Add support to report standard deviation Punit Agrawal
2021-10-14 11:50 ` Daniel Wagner
2021-10-15 7:58 ` Punit Agrawal
2021-10-15 8:22 ` Daniel Wagner
2021-10-15 16:37 ` [RFC 0/7] " Joseph Salisbury
2021-10-18 0:28 ` Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211014071247.4165329-6-punitagrawal@gmail.com \
--to=punitagrawal@gmail.com \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=punit1.agrawal@toshiba.co.jp \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox