Re: [PATCH V4 02/19] trace/osnoise: Split workload start from the tracer start

Steven Rostedt
2021-10-23T02:25:22Z

On Thu, 21 Oct 2021 14:56:40 +0200
Daniel Bristot de Oliveira <bristot@kernel.org> wrote:

> +/*
> + * osnoise_workload_stop - stop the workload and unhook the events
> + */
> +static void osnoise_workload_stop(void)
> +{
> + if (!osnoise_busy)
> + return;
> +
> + trace_osnoise_callback_enabled = false;

I know this is just moving this code, but the original code had this
issue too, but there should be a comment here to why we need the
compiler barrier.

-- Steve

> + barrier();
> +
> + stop_per_cpu_kthreads();
> +
> + unhook_irq_events();
> + unhook_softirq_events();
> + unhook_thread_events();
> +
> + osnoise_busy = false;
> +}
> +