From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89E91C433EF for ; Mon, 11 Jul 2022 16:37:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230039AbiGKQhe (ORCPT ); Mon, 11 Jul 2022 12:37:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229542AbiGKQhd (ORCPT ); Mon, 11 Jul 2022 12:37:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FAFA2CCA3; Mon, 11 Jul 2022 09:37:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0639761278; Mon, 11 Jul 2022 16:37:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 676A6C34115; Mon, 11 Jul 2022 16:37:30 +0000 (UTC) Date: Mon, 11 Jul 2022 12:37:28 -0400 From: Steven Rostedt To: John Ogness Cc: Schspa Shi , pmladek@suse.com, sergey.senozhatsky@gmail.com, linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org, bigeasy@linutronix.de, tglx@linutronix.de, "Luis Claudio R. Goncalves" Subject: Re: [PATCH 5.10-rt] printk: fix suppressed message print when reboot/panic Message-ID: <20220711123728.79bc0f93@gandalf.local.home> In-Reply-To: <20220711123128.1278e203@gandalf.local.home> References: <20220321053815.71316-1-schspa@gmail.com> <87a6dj3b5c.fsf@jogness.linutronix.de> <20220711123128.1278e203@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-rt-users@vger.kernel.org I guess the lclaudio@uudg.org is no longer valid. I need to update my address book :-/ On Mon, 11 Jul 2022 12:31:28 -0400 Steven Rostedt wrote: > Luis, > > Care to add this patch into the 5.10-rt stable? > > Thanks, > > -- Steve > > On Mon, 21 Mar 2022 10:36:55 +0106 > John Ogness wrote: > > > On 2022-03-21, Schspa Shi wrote: > > > Update printk_seq for suppressed message. > > > > > > Affects 5.9-rt and 5.10-rt > > > > > > When message is suppressed, printk_seq should be updated, otherwise > > > this message will be printed when reboot. This problem was introduced > > > in commit 3edc0c85d154 ("printk: Rebase on top of new ring buffer"). > > > > > > Signed-off-by: Schspa Shi > > > > Reviewed-by: John Ogness > > > > Nice catch. Thanks. > > > > 5.15-rt also has this issue, although the fix is slightly different. For > > 5.15-rt, writing to con->printk_seq (via latched_seq_write()) requires > > the console locked. Would you like to post a patch for 5.15-rt as well, > > or would you like me to do it? > > > > 5.16 and beyond does not have this issue. > > > > John Ogness >