From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: "Brennan Lamoreaux (VMware)" <brennanlamoreaux@gmail.com>,
Daniel Wagner <wagi@monom.org>
Cc: linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org,
blamoreaux@vmware.com, frederic.martinsons@gmail.com,
srivatsa@csail.mit.edu, vsirnapalli@vmware.com,
amakhalov@vmware.com, keerthanak@vmware.com, ankitja@vmware.com,
bordoloih@vmware.com, srivatsab@vmware.com,
Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH 4.19-rt] workqueue: Fix deadlock due to recursive locking of pool->lock
Date: Mon, 13 Mar 2023 10:36:41 +0100 [thread overview]
Message-ID: <20230313093641.pxvwFHCJ@linutronix.de> (raw)
In-Reply-To: <20230228224938.88035-1-brennanlamoreaux@gmail.com>
On 2023-02-28 14:49:38 [-0800], Brennan Lamoreaux (VMware) wrote:
> Upstream commit d8bb65ab70f7 ("workqueue: Use rcuwait for wq_manager_wait")
> replaced the waitqueue with rcuwait in the workqueue code. This change
> involved removing the acquisition of pool->lock in put_unbound_pool(),
> as it also adds the function wq_manager_inactive() which acquires this same
> lock and is called one line later as a parameter to rcu_wait_event().
Daniel, I double checked and this patch is correct - the backport was
faulty. Could you please pick it up and release an update?
Sebastian
next prev parent reply other threads:[~2023-03-13 9:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 22:49 [PATCH 4.19-rt] workqueue: Fix deadlock due to recursive locking of pool->lock Brennan Lamoreaux (VMware)
2023-02-28 23:03 ` Srivatsa S. Bhat
2023-03-13 9:36 ` Sebastian Andrzej Siewior [this message]
2023-03-16 7:08 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230313093641.pxvwFHCJ@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=amakhalov@vmware.com \
--cc=ankitja@vmware.com \
--cc=blamoreaux@vmware.com \
--cc=bordoloih@vmware.com \
--cc=brennanlamoreaux@gmail.com \
--cc=frederic.martinsons@gmail.com \
--cc=keerthanak@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=srivatsa@csail.mit.edu \
--cc=srivatsab@vmware.com \
--cc=tj@kernel.org \
--cc=vsirnapalli@vmware.com \
--cc=wagi@monom.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox