public inbox for linux-rt-users@vger.kernel.org
 help / color / mirror / Atom feed
From: "Luis Claudio R. Goncalves" <lgoncalv@redhat.com>
To: linux-rt-users <linux-rt-users@vger.kernel.org>,
	stable-rt <stable-rt@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Carsten Emde <C.Emde@osadl.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Daniel Wagner <daniel.wagner@suse.com>,
	Tom Zanussi <tom.zanussi@linux.intel.com>,
	Clark Williams <williams@redhat.com>,
	Mark Gross <markgross@kernel.org>,
	Jeff Brady <jeffreyjbrady@gmail.com>,
	Luis Goncalves <lgoncalv@redhat.com>
Subject: [PATCH RT 1/3] Revert "printk: declare printk_deferred_{enter,safe}() in include/linux/printk.h"
Date: Thu,  8 Jun 2023 22:11:02 -0300	[thread overview]
Message-ID: <20230609011104.967128-2-lgoncalv@redhat.com> (raw)
In-Reply-To: <20230609011104.967128-1-lgoncalv@redhat.com>

v5.10.180-rt89-rc1 stable review patch.
If anyone has any objections, please let me know.

-----------


This reverts commit 32232bcd4e5300e678718d5c29da4dfa07ade01e.

The support for deferred printing was removed in v5.10-rc1-rt1 by commit
9153e3c5cb0c9 ("printk: remove deferred printing") because:

    Since printing occurs either atomically or from the printing
    kthread, there is no need for any deferring or tracking possible
    recursion paths. Remove all printk context tracking.

Fixes: 32232bcd4e530 ("printk: declare printk_deferred_{enter,safe}() in include/linux/printk.h")
Fixes: 083183f8bea0f ("rt: printk: remove new references to deferred printing")
Signed-off-by: Luis Claudio R. Goncalves <lgoncalv@redhat.com>
---
 include/linux/printk.h | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/include/linux/printk.h b/include/linux/printk.h
index 92e0656841128..7e4352467d831 100644
--- a/include/linux/printk.h
+++ b/include/linux/printk.h
@@ -609,23 +609,4 @@ static inline void print_hex_dump_debug(const char *prefix_str, int prefix_type,
 #define print_hex_dump_bytes(prefix_str, prefix_type, buf, len)	\
 	print_hex_dump_debug(prefix_str, prefix_type, 16, 1, buf, len, true)
 
-#if defined(CONFIG_PRINTK) && !defined(CONFIG_PREEMPT_RT)
-extern void __printk_safe_enter(void);
-extern void __printk_safe_exit(void);
-/*
- * The printk_deferred_enter/exit macros are available only as a hack for
- * some code paths that need to defer all printk console printing. Interrupts
- * must be disabled for the deferred duration.
- */
-#define printk_deferred_enter __printk_safe_enter
-#define printk_deferred_exit __printk_safe_exit
-#else /* defined(CONFIG_PRINTK) && !defined(CONFIG_PREEMPT_RT) */
-static inline void printk_deferred_enter(void)
-{
-}
-static inline void printk_deferred_exit(void)
-{
-}
-#endif
-
 #endif
-- 
2.40.1


  reply	other threads:[~2023-06-09  1:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-09  1:11 [PATCH RT 0/3] Linux v5.10.180-rt89-rc1 Luis Claudio R. Goncalves
2023-06-09  1:11 ` Luis Claudio R. Goncalves [this message]
2023-06-09  1:11 ` [PATCH RT 2/3] Revert "mm/page_alloc: fix potential deadlock on zonelist_update_seqseqlock" Luis Claudio R. Goncalves
2023-06-09  1:11 ` [PATCH RT 3/3] Linux 5.10.180-rt89-rc1 Luis Claudio R. Goncalves
2023-06-20 15:53   ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230609011104.967128-2-lgoncalv@redhat.com \
    --to=lgoncalv@redhat.com \
    --cc=C.Emde@osadl.org \
    --cc=bigeasy@linutronix.de \
    --cc=daniel.wagner@suse.com \
    --cc=jeffreyjbrady@gmail.com \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=markgross@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=stable-rt@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tom.zanussi@linux.intel.com \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox