From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: "Li, Meng" <Meng.Li@windriver.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
USB mailing list <linux-usb@vger.kernel.org>,
linux-rt-users <linux-rt-users@vger.kernel.org>
Subject: Re: USB: add check to detect host controller hardware removal
Date: Thu, 19 Oct 2023 14:38:23 +0200 [thread overview]
Message-ID: <20231019123823.4fjUs8Rl@linutronix.de> (raw)
In-Reply-To: <1f8fe9f9-d8d6-48d9-8c7d-1215d10ece91@rowland.harvard.edu>
On 2023-10-18 11:20:46 [-0400], Alan Stern wrote:
>
> If you hadn't removed the card suddenly, the exception would not have
> occurred. So the logical conclusion isn't that we should get rid of the
> usb_hcd_irq(0, hcd) call -- the logical conclusion is that you shouldn't
> remove PCIe cards while the system is running. Not unless your computer
> uses the special hardware from Stratus Technologies.
So the card was removed and the kernel complained that it can't access
the memory behind the PCI-bar?
How odd…
> > so I think we don't need to add usb_hcd_irq(0, hcd) on the logical path of unbinding pcie driver.
>
> What about cardbus or PCMCIA cards? Removing one of those cards
> suddenly, while the system is running, is a perfectly reasonable thing
> to do and it will not cause any hardware damage. So I think we should
> keep the usb_hcd_irq(0, hcd) call.
Don't you invoke pci_driver::remove in such case to properly let the
physical device go? This can also be tested via unbind from sysfs.
> Alan Stern
Sebastian
next prev parent reply other threads:[~2023-10-19 12:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <PH0PR11MB5191464B2F01511D2ADECB3BF1D2A@PH0PR11MB5191.namprd11.prod.outlook.com>
[not found] ` <9a1074e2-c1ae-485b-b5e7-a34442c98c0b@rowland.harvard.edu>
2023-10-16 16:56 ` USB: add check to detect host controller hardware removal Steven Rostedt
2023-10-16 19:23 ` Alan Stern
2023-10-17 2:23 ` Li, Meng
2023-10-17 14:06 ` Alan Stern
2023-10-18 5:00 ` Li, Meng
2023-10-18 15:20 ` Alan Stern
2023-10-18 15:34 ` Alan Stern
2023-10-19 12:38 ` Sebastian Andrzej Siewior [this message]
2023-10-19 15:09 ` Alan Stern
2023-10-19 15:27 ` Alan Stern
2023-10-20 9:52 ` Sebastian Andrzej Siewior
2023-10-20 15:19 ` Alan Stern
2023-11-03 15:46 ` Sebastian Andrzej Siewior
2023-11-03 20:42 ` Alan Stern
2023-11-06 3:02 ` Li, Meng
2023-11-06 8:28 ` Sebastian Andrzej Siewior
2023-11-06 8:54 ` Li, Meng
2023-11-06 9:09 ` Sebastian Andrzej Siewior
2023-11-07 3:08 ` Li, Meng
2023-11-07 6:17 ` Greg KH
2023-11-06 15:25 ` Alan Stern
2023-11-06 8:27 ` Sebastian Andrzej Siewior
2023-10-19 12:49 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231019123823.4fjUs8Rl@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=Meng.Li@windriver.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox