From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: "Chang, Junxiao" <junxiao.chang@intel.com>
Cc: John Ogness <john.ogness@linutronix.de>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Li, Hao3" <hao3.li@intel.com>, "Li, Lili" <lili.li@intel.com>,
"Gao, Jianfeng" <jianfeng.gao@intel.com>,
"linux-rt-users@vger.kernel.org" <linux-rt-users@vger.kernel.org>
Subject: Re: RE: [PATCH 1/2] printk: nbcon: move locked_port flag to struct uart_port
Date: Thu, 25 Jan 2024 14:35:23 +0100 [thread overview]
Message-ID: <20240125133523.W7aDeBqt@linutronix.de> (raw)
In-Reply-To: <BN9PR11MB53701E5CF2737908FA9EB532EC7A2@BN9PR11MB5370.namprd11.prod.outlook.com>
On 2024-01-25 01:08:24 [+0000], Chang, Junxiao wrote:
>
> Issue could be reproduced with our hardware every time. My cmdline is:
> BOOT_IMAGE=(hd0,gpt2)/boot/bzImage-linux-intel-iot-lts-rt-6.6-kernel
> root=PARTLABEL=primary rootwait console=ttyS0,115200 console=tty0
> init=/sbin/preinit-env console=ttyS4,115200n8 console=ttyS5,115200n8
>
> If you would like to try any debug patch with my ADL hardware, please feel free to let me know.
>
> For console pointer sharing issue, from code logic point of view, the call chain looks like:
> serial8250_register_8250_port -> uart_add_one_port -> serial_ctrl_register_port -> serial_core_register_port -> serial_core_add_one_port
>
> In API serial_core_add_one_port, uart_port's console pointer is assigned with driver's console pointer:
> uport->cons = drv->cons;
> Driver's console pointer points to static structure "univ8250_console" which is defined in 8250_core.c
>
> That is, all 8250 serial devices' console pointer are same, they point to univ8250_console.
Okay, So that I see this and the unbalanced acquire/ release part with
the attached patch. I leave it to John…
Btw. You don't see kernel log output on ttyS4 + ttyS5, right? Just a
login prompt.
…
> Thanks,
> Junxiao
Sebastian
next prev parent reply other threads:[~2024-01-25 13:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 6:52 [PATCH] printk: nbcon: check uart port is nbcon or not in nbcon_release Junxiao Chang
2024-01-17 8:23 ` John Ogness
2024-01-17 8:45 ` Chang, Junxiao
2024-01-17 10:03 ` John Ogness
2024-01-17 10:24 ` Sebastian Andrzej Siewior
2024-01-17 13:08 ` Chang, Junxiao
2024-01-17 13:42 ` John Ogness
2024-01-23 3:05 ` Chang, Junxiao
2024-01-23 5:40 ` [PATCH 0/2] nbcon locking issue with v6.6.10-rt18 kernel Junxiao Chang
2024-01-23 5:40 ` [PATCH 1/2] printk: nbcon: move locked_port flag to struct uart_port Junxiao Chang
2024-01-24 9:47 ` John Ogness
2024-01-24 10:05 ` Sebastian Andrzej Siewior
2024-01-25 1:08 ` Chang, Junxiao
2024-01-25 13:35 ` Sebastian Andrzej Siewior [this message]
2024-01-25 23:20 ` Chang, Junxiao
2024-01-26 7:58 ` John Ogness
2024-01-26 16:39 ` Sebastian Andrzej Siewior
2024-01-23 5:40 ` [PATCH 2/2] printk: nbcon: check uart port is nbcon or not in nbcon_release Junxiao Chang
2024-01-24 9:57 ` John Ogness
2024-01-26 2:33 ` Chang, Junxiao
2024-01-24 9:40 ` [PATCH 0/2] nbcon locking issue with v6.6.10-rt18 kernel John Ogness
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240125133523.W7aDeBqt@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=hao3.li@intel.com \
--cc=jianfeng.gao@intel.com \
--cc=john.ogness@linutronix.de \
--cc=junxiao.chang@intel.com \
--cc=lili.li@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox