From: Steven Rostedt <rostedt@goodmis.org>
To: Petr Pavlu <petr.pavlu@suse.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rt-users <linux-rt-users@vger.kernel.org>
Subject: Re: [PATCH 2/2] ring-buffer: Fix a race between readers and resize checks
Date: Mon, 10 Jun 2024 11:56:58 -0400 [thread overview]
Message-ID: <20240610115658.27623de4@rorschach.local.home> (raw)
In-Reply-To: <8f5dca5a-330d-4258-8e01-0734ffda361d@suse.com>
On Fri, 7 Jun 2024 10:29:03 +0200
Petr Pavlu <petr.pavlu@suse.com> wrote:
> Another option could be to try traversing the whole list in smaller
> parts and give up the reader_lock in between them. This would need some
> care to make sure that the operation completes, e.g. the code would need
> to bail out if it detects a change on cpu_buffer->pages_read.
I think I like this approach the most. Perhaps even have a counter that
gets incremented everything a new reader page is taken. And if it
detects that, it restarts the check?
To prevent a DOS, we restart 3 times at most, and then just say "the
list is OK" and exit.
So basically, we release the lock within the loop per each sub-buffer,
and then check if the reader touch it when reacquiring the lock.
-- Steve
prev parent reply other threads:[~2024-06-10 15:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240517134008.24529-1-petr.pavlu@suse.com>
[not found] ` <20240517134008.24529-3-petr.pavlu@suse.com>
2024-05-20 13:50 ` [PATCH 2/2] ring-buffer: Fix a race between readers and resize checks Steven Rostedt
2024-05-27 9:36 ` Petr Pavlu
2024-05-27 23:43 ` Steven Rostedt
2024-06-07 8:29 ` Petr Pavlu
2024-06-10 15:56 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240610115658.27623de4@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=petr.pavlu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox