From: ende.tan@starfivetech.com
To: linux-rt-users@vger.kernel.org, mtosatti@redhat.com
Cc: williams@redhat.com, jkacur@redhat.com,
leyfoon.tan@starfivetech.com,
Tan En De <ende.tan@starfivetech.com>
Subject: [1/1] rt-tests: queuelat: Fix wraparound in __clock_gettime()
Date: Mon, 11 Nov 2024 09:49:11 +0800 [thread overview]
Message-ID: <20241111014911.11571-1-ende.tan@starfivetech.com> (raw)
From: Tan En De <ende.tan@starfivetech.com>
Include tv_sec in addition to tv_nsec in __clock_gettime(). If the value
of variable 'a' wraps around, it may cause 'delta' to be negative, while
'delta' is defined with u64 type.
Signed-off-by: Tan En De <ende.tan@starfivetech.com>
---
src/queuelat/queuelat.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/queuelat/queuelat.c b/src/queuelat/queuelat.c
index c549cd8..c057389 100644
--- a/src/queuelat/queuelat.c
+++ b/src/queuelat/queuelat.c
@@ -292,7 +292,8 @@ static inline unsigned long long __clock_gettime(void)
if (ret < 0)
return 0;
- return now.tv_nsec;
+ // Combine seconds and nanoseconds into a single value in nanoseconds
+ return (unsigned long long)now.tv_sec * 1000000000ULL + now.tv_nsec;
}
#define gettick(val) do { (val) = __clock_gettime(); } while (0)
--
2.34.1
next reply other threads:[~2024-11-11 5:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 1:49 ende.tan [this message]
2024-11-19 19:48 ` [1/1] rt-tests: queuelat: Fix wraparound in __clock_gettime() Marcelo Tosatti
2024-11-21 18:48 ` John Kacur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241111014911.11571-1-ende.tan@starfivetech.com \
--to=ende.tan@starfivetech.com \
--cc=jkacur@redhat.com \
--cc=leyfoon.tan@starfivetech.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox