From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Tomas Glozar <tglozar@redhat.com>
Cc: Crystal Wood <crwood@redhat.com>, John Kacur <jkacur@redhat.com>,
linux-rt-users@vger.kernel.org, williams@redhat.com
Subject: Re: [PATCH v2 2/3] rt-tests: cyclictest: Support idle state disabling via libcpupower
Date: Fri, 6 Dec 2024 12:52:01 +0100 [thread overview]
Message-ID: <20241206115201.RJsDmOXi@linutronix.de> (raw)
In-Reply-To: <CAP4=nvTZ5nLrP6O7rSU+c269M-=OFTX=3zNSp6TDDxzg2Fq2fg@mail.gmail.com>
On 2024-11-27 10:45:49 [+0100], Tomas Glozar wrote:
> st 27. 11. 2024 v 1:09 odesílatel Crystal Wood <crwood@redhat.com> napsal:
> >
> > This could be said about the laptop and power_management checks too...
> > I'd go with verbose info prints rather than warnings for all three, if
> > anything.
> >
>
> I agree. I believe my code is consistent with what we already have.
> When you do cyclictest --default-system, you also get a warning about
> not setting cpu_dma_latency, despite it being what you have explicitly
> requested. My patch just does the same thing for --deepest-idle-state.
What is the default behaviour and what is the intended behaviour?
Couldn't we somehow avoid adding yet another option?
> I suggest deferring this to a future patch that would remove the
> warnings and another one to refactor the code.
Sebastian
next prev parent reply other threads:[~2024-12-06 11:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 11:45 [PATCH v2 0/3] rt-tests: cyclictest: Support idle state disabling via libcpupower tglozar
2024-11-13 11:45 ` [PATCH v2 1/3] rt-tests: Detect libcpupower presence tglozar
2024-11-13 11:45 ` [PATCH v2 2/3] rt-tests: cyclictest: Support idle state disabling via libcpupower tglozar
2024-11-26 22:29 ` John Kacur
2024-11-27 0:08 ` Crystal Wood
2024-11-27 9:45 ` Tomas Glozar
2024-11-27 15:51 ` John Kacur
2024-12-06 11:52 ` Sebastian Andrzej Siewior [this message]
2024-12-06 12:14 ` Tomas Glozar
2024-12-06 14:41 ` Sebastian Andrzej Siewior
2024-12-06 15:29 ` John Kacur
2024-11-27 15:47 ` John Kacur
2024-12-02 19:30 ` Crystal Wood
2024-11-13 11:45 ` [PATCH v2 3/3] rt-tests: cyclictest: Add --deepest-idle-state to manpage tglozar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241206115201.RJsDmOXi@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=crwood@redhat.com \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=tglozar@redhat.com \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox