public inbox for linux-rt-users@vger.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Robert Joslyn <robert_joslyn@selinc.com>
Cc: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org,
	tglx@linutronix.de, rostedt@goodmis.org,
	Shrikanth Hegde <sshegde@linux.ibm.com>
Subject: Re: [PATCH] powerpc: Allow scheduling of IRQ with PREEMPT_RT
Date: Tue, 7 Jan 2025 12:56:06 +0100	[thread overview]
Message-ID: <20250107115606.q67--i0f@linutronix.de> (raw)
In-Reply-To: <20241226191238.2559880-1-robert_joslyn@selinc.com>

On 2024-12-26 11:12:38 [-0800], Robert Joslyn wrote:
> This branch is needed to allow preemptible IRQs to be scheduled,
> otherwise the kernel hangs during boot on my e300 based platforms.
> This branch is needed for both CONFIG_PREEMPT and CONFIG_PREEMPT_RT,
> so broaden the check to CONFIG_PREEMPTION, which is selected by both.
> 
> This was previously set to CONFIG_PREEMPTION, but was reverted as part
> of removing LAZY_PREEMPT support.

I remember I pointed this out while Shrikanth posted the preempt-lazy
patches but didn't realize that I need this in RT tree, too.

The lazy-preempt patches for powerpc were merged upstream, I am going to
pull them into the v6.6-series.
I am going to Cc you, hopefully you can confirm that it is working.

> Fixes: b33022a48c79
> Signed-off-by: Robert Joslyn <robert_joslyn@selinc.com>
> ---
>  arch/powerpc/kernel/interrupt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/kernel/interrupt.c b/arch/powerpc/kernel/interrupt.c
> index af62ec974b97..970039af8e92 100644
> --- a/arch/powerpc/kernel/interrupt.c
> +++ b/arch/powerpc/kernel/interrupt.c
> @@ -396,7 +396,7 @@ notrace unsigned long interrupt_exit_kernel_prepare(struct pt_regs *regs)
>  		/* Returning to a kernel context with local irqs enabled. */
>  		WARN_ON_ONCE(!(regs->msr & MSR_EE));
>  again:
> -		if (IS_ENABLED(CONFIG_PREEMPT)) {
> +		if (IS_ENABLED(CONFIG_PREEMPTION)) {
>  			/* Return to preemptible kernel context */
>  			if (unlikely(read_thread_flags() & _TIF_NEED_RESCHED)) {
>  				if (preempt_count() == 0)

Sebastian

  reply	other threads:[~2025-01-07 11:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-26 19:12 [PATCH] powerpc: Allow scheduling of IRQ with PREEMPT_RT Robert Joslyn
2025-01-07 11:56 ` Sebastian Andrzej Siewior [this message]
2025-01-07 11:58   ` Sebastian Andrzej Siewior
2025-01-07 18:09     ` Robert Joslyn
2025-01-09 11:44       ` Sebastian Andrzej Siewior
2025-01-10 22:36         ` Robert Joslyn
2025-01-07 13:10   ` Shrikanth Hegde
2025-01-07 18:13     ` Robert Joslyn
2025-01-08  4:56       ` Shrikanth Hegde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250107115606.q67--i0f@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=robert_joslyn@selinc.com \
    --cc=rostedt@goodmis.org \
    --cc=sshegde@linux.ibm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox