From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Rafael Folco <rfolco@redhat.com>
Cc: williams@redhat.com, jkacur@redhat.com, linux-rt-users@vger.kernel.org
Subject: Re: [PATCH] Change min/max to float numbers
Date: Thu, 6 Feb 2025 16:36:38 +0100 [thread overview]
Message-ID: <20250206153638.vagnFWGA@linutronix.de> (raw)
In-Reply-To: <01ce78a4-0780-4af0-a9ca-6f654934ec9e@redhat.com>
On 2025-02-06 12:24:42 [-0300], Rafael Folco wrote:
> > so core 3 has min 33ns and max 129ns while 1us on average?
> Yes, because avg rounds up.
> There are some other potential fixes coming like:
> - stop rounding up avg
> - splitting bucket 001 (us) which is bigger (0 - 1.99999)
> - adding the max bucket to the end (do not limit to 32us)
>
> ... but these are out of scope for this change.
I'm not totally against floating point numbers here but you should add
the bullet numbers to your patch description. Also you might lose
precision over time if you deal with floating point.
However what you just showed me looks like the statistics part is
working right. I mean max lower than average. At least it is above min.
> Folco
Sebastian
next prev parent reply other threads:[~2025-02-06 15:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 9:16 [PATCH] Change min/max to float numbers Rafael Folco
2025-02-06 12:00 ` Sebastian Andrzej Siewior
2025-02-06 15:02 ` Rafael Folco
2025-02-06 15:09 ` Sebastian Andrzej Siewior
2025-02-06 15:24 ` Rafael Folco
2025-02-06 15:36 ` Sebastian Andrzej Siewior [this message]
2025-02-06 16:22 ` Rafael Folco
2025-02-06 21:23 ` Crystal Wood
2025-02-07 14:20 ` Rafael Folco
2025-02-07 23:23 ` Crystal Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250206153638.vagnFWGA@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=rfolco@redhat.com \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).