linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cheng-Yang Chou <yphbchou0911@gmail.com>
To: williams@redhat.com, jkacur@redhat.com
Cc: linux-rt-users@vger.kernel.org, jserv@ccns.ncku.edu.tw,
	yphbchou0911@gmail.com
Subject: [PATCH v2 7/8] sigwaittest.c: Check return values of write() and ftruncate()
Date: Sat, 26 Jul 2025 17:18:36 +0800	[thread overview]
Message-ID: <20250726091837.493915-8-yphbchou0911@gmail.com> (raw)
In-Reply-To: <20250726091837.493915-1-yphbchou0911@gmail.com>

Add error handling for write() to tracefs and ftruncate() on shared memory
to avoid ignoring errors.

Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>
---
 src/sigwaittest/sigwaittest.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/src/sigwaittest/sigwaittest.c b/src/sigwaittest/sigwaittest.c
index 026cc81..3944b54 100644
--- a/src/sigwaittest/sigwaittest.c
+++ b/src/sigwaittest/sigwaittest.c
@@ -72,6 +72,7 @@ void *semathread(void *param)
 	cpu_set_t mask;
 	int policy = SCHED_FIFO;
 	struct sched_param schedp;
+	int ret;
 
 	memset(&schedp, 0, sizeof(schedp));
 	schedp.sched_priority = par->priority;
@@ -168,7 +169,10 @@ void *semathread(void *param)
 				int tracing_enabled =
 				    open(tracing_enabled_file, O_WRONLY);
 				if (tracing_enabled >= 0) {
-					write(tracing_enabled, "0", 1);
+					ret = write(tracing_enabled, "0", 1);
+					if (ret < 0)
+						fatal("Could not write to %s: %s\n",
+						      tracing_enabled_file, strerror(errno));
 					close(tracing_enabled);
 				} else
 					fatal("Could not access %s\n",
@@ -489,7 +493,12 @@ int main(int argc, char *argv[])
 			fprintf(stderr, "Could not create shared memory\n");
 			return 1;
 		}
-		ftruncate(shmem, totalsize);
+		if (ftruncate(shmem, totalsize) == -1) {
+			perror("ftruncate failed");
+			close(shmem);
+			shm_unlink("/sigwaittest");
+			return 1;
+		}
 		param = mmap(0, totalsize, PROT_READ|PROT_WRITE, MAP_SHARED,
 		    shmem, 0);
 		if (param == MAP_FAILED) {
-- 
2.48.1


  parent reply	other threads:[~2025-07-26  9:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-26  9:18 [PATCH v2 0/8] Fix -Wunused-result warnings by checking return values Cheng-Yang Chou
2025-07-26  9:18 ` [PATCH v2 1/8] rt-utils.c: Check return values of write() Cheng-Yang Chou
2025-09-26 17:38   ` John Kacur
2025-07-26  9:18 ` [PATCH v2 2/8] pmqtest.c: Check return values of write() and ftruncate() Cheng-Yang Chou
2025-09-26 17:40   ` John Kacur
2025-07-26  9:18 ` [PATCH v2 3/8] ptsematest.c: " Cheng-Yang Chou
2025-09-26 17:57   ` John Kacur
2025-07-26  9:18 ` [PATCH v2 4/8] rt-migrate-test.c: " Cheng-Yang Chou
2025-09-26 19:49   ` John Kacur
2025-07-26  9:18 ` [PATCH v2 5/8] cyclicdeadline.c: " Cheng-Yang Chou
2025-09-26 19:58   ` John Kacur
2025-07-26  9:18 ` [PATCH v2 6/8] deadline_test.c: " Cheng-Yang Chou
2025-09-26 20:00   ` John Kacur
2025-07-26  9:18 ` Cheng-Yang Chou [this message]
2025-09-26 20:01   ` [PATCH v2 7/8] sigwaittest.c: " John Kacur
2025-07-26  9:18 ` [PATCH v2 8/8] svsematest.c: " Cheng-Yang Chou
2025-09-26 20:03   ` John Kacur
2025-08-07 16:26 ` [PATCH v2 0/8] Fix -Wunused-result warnings by checking return values Cheng-Yang Chou
2025-08-23 12:40   ` Cheng-Yang Chou
2025-09-05 18:27     ` Cheng-Yang Chou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250726091837.493915-8-yphbchou0911@gmail.com \
    --to=yphbchou0911@gmail.com \
    --cc=jkacur@redhat.com \
    --cc=jserv@ccns.ncku.edu.tw \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).