From: Clark Williams <clrkwllms@kernel.org>
To: linux-rt-users@vger.kernel.org
Cc: Clark Williams <williams@redhat.com>,
Clark Williams <clrkwllms@kernel.org>,
wander@redhat.com, debarbos@redhat.com, marco.chiappero@suse.com,
chris.friesen@windriver.com, luochunsheng@ustc.edu
Subject: [PATCH 05/12] stalld.c: initialize cpu_info->idle_time to be -1
Date: Thu, 16 Oct 2025 21:24:37 -0500 [thread overview]
Message-ID: <20251017022444.118802-5-clrkwllms@kernel.org> (raw)
In-Reply-To: <20251017022444.118802-1-clrkwllms@kernel.org>
From: Clark Williams <williams@redhat.com>
Initialize the idle_time value of a cpu_info structure to be -1 so
that it will be presumed busy for the first time through the loop,
which will force an initial check of the run queues.
Signed-off-by: Clark Williams <clrkwllms@kernel.org>
Signed-off-by: Clark Williams <williams@redhat.com>
---
src/stalld.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/src/stalld.c b/src/stalld.c
index e8c927750ee0..6cd4bf68d04a 100644
--- a/src/stalld.c
+++ b/src/stalld.c
@@ -293,6 +293,15 @@ int get_cpu_busy_list(struct cpu_info *cpus, int nr_cpus, char *busy_cpu_list)
* log_verbose ("\t cpu %d had %ld idle time, and now has %ld\n",
* cpu->id, cpu->idle_time, idle_time);
*/
+
+ /* If this is the first check (idle_time was -1), assume busy to be safe */
+ if (cpu->idle_time == -1) {
+ cpu->idle_time = idle_time;
+ busy_cpu_list[i] = 1;
+ busy_count++;
+ continue;
+ }
+
/* If the idle time did not change, the CPU is busy. */
if (cpu->idle_time == idle_time) {
busy_cpu_list[i] = 1;
@@ -1168,6 +1177,7 @@ int main(int argc, char **argv)
for (i = 0; i < config_nr_cpus; i++) {
cpus[i].buffer = allocate_memory(1, config_buffer_size);
cpus[i].buffer_size = config_buffer_size;
+ cpus[i].idle_time = -1; /* Initialize to -1 so first check doesn't skip busy CPUs */
}
if (config_log_syslog)
--
2.51.0
next prev parent reply other threads:[~2025-10-17 2:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 2:24 [PATCH 01/12] sched_debug: Unify parsing methods for task_info Clark Williams
2025-10-17 2:24 ` [PATCH 02/12] sched_debug: Fix runqueue task parsing logic and state filtering Clark Williams
2025-10-21 15:58 ` Wander Lairson Costa
2025-10-17 2:24 ` [PATCH 03/12] sched_debug: Fix double-free crash in fill_waiting_task() Clark Williams
2025-10-21 16:01 ` Wander Lairson Costa
2025-10-17 2:24 ` [PATCH 04/12] stalld.c: remove noisy idle report and added report to should_skip_idle_cpus() Clark Williams
2025-10-21 16:03 ` Wander Lairson Costa
2025-10-17 2:24 ` Clark Williams [this message]
2025-10-21 16:15 ` [PATCH 05/12] stalld.c: initialize cpu_info->idle_time to be -1 Wander Lairson Costa
2025-10-17 2:24 ` [PATCH 06/12] stalld.c: get rid of misleading print about DL-Server Clark Williams
2025-10-21 16:16 ` Wander Lairson Costa
2025-10-17 2:24 ` [PATCH 07/12] stalld.c: Add starvation logging in single-threaded log-only mode Clark Williams
2025-10-21 16:27 ` Wander Lairson Costa
2025-10-17 2:24 ` [PATCH 08/12] stalld: Add -N/--no_idle_detect flag to disable idle detection Clark Williams
2025-10-21 16:33 ` Wander Lairson Costa
2025-10-17 2:24 ` [PATCH 09/12] stalld: Add defensive checks in print_boosted_info Clark Williams
2025-10-21 17:36 ` Wander Lairson Costa
2025-10-17 2:24 ` [PATCH 10/12] Makefile: Add support for legacy kernels Clark Williams
2025-10-17 12:50 ` Derek Barbosa
2025-10-21 17:43 ` Wander Lairson Costa
2025-10-17 2:24 ` [PATCH 11/12] scripts: fix run-local if bashism Clark Williams
2025-10-21 17:45 ` Wander Lairson Costa
2025-10-17 2:24 ` [PATCH 12/12] Fix segfault in adaptive/aggressive modes Clark Williams
2025-10-21 17:45 ` Wander Lairson Costa
2025-10-21 15:54 ` [PATCH 01/12] sched_debug: Unify parsing methods for task_info Wander Lairson Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251017022444.118802-5-clrkwllms@kernel.org \
--to=clrkwllms@kernel.org \
--cc=chris.friesen@windriver.com \
--cc=debarbos@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=luochunsheng@ustc.edu \
--cc=marco.chiappero@suse.com \
--cc=wander@redhat.com \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox