From: Wander Lairson Costa <wander@redhat.com>
To: williams@redhat.com
Cc: linux-rt-users@vger.kernel.org,
Wander Lairson Costa <wander@redhat.com>,
Derek Barbosa <debarbos@redhat.com>,
John Kacur <jkacur@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Chunsheng Luo <luochunsheng@ustc.edu>
Subject: [PATCH 1/3] Makefile: Conditionally add -mno-omit-leaf-frame-pointer
Date: Fri, 7 Nov 2025 13:17:26 -0300 [thread overview]
Message-ID: <20251107161729.320087-2-wander@redhat.com> (raw)
In-Reply-To: <20251107161729.320087-1-wander@redhat.com>
The -mno-omit-leaf-frame-pointer option is not available on all
architectures (e.g., s390x) or with older compiler versions. To avoid
compilation errors on such systems, this change adds a check to ensure
the option is only used when the compiler supports it.
This approach is similar to the existing check for -fcf-protection.
Signed-off-by: Wander Lairson Costa <wander@redhat.com>
Cc: Derek Barbosa <debarbos@redhat.com>
Cc: John Kacur <jkacur@redhat.com>
Cc: Juri Lelli <juri.lelli@redhat.com>
Cc: Chunsheng Luo <luochunsheng@ustc.edu>
---
Makefile | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index c19e0bd..d605e60 100644
--- a/Makefile
+++ b/Makefile
@@ -60,7 +60,13 @@ FOPTS := -flto=auto -ffat-lto-objects -fexceptions -fstack-protector-strong \
-fasynchronous-unwind-tables -fstack-clash-protection -fno-omit-frame-pointer \
$(strip $(FCF_PROTECTION)) -fpie
-MOPTS := $(strip $(MTUNE)) $(strip $(M64)) -mno-omit-leaf-frame-pointer
+# Test if compiler supports -mno-omit-leaf-frame-pointer
+OMIT_LEAF_FP := $(shell echo 'int main(void){return 0;}' | \
+ $(CC) -x c -mno-omit-leaf-frame-pointer - \
+ -o /dev/null 2>/dev/null && \
+ echo '-mno-omit-leaf-frame-pointer')
+
+MOPTS := $(strip $(MTUNE)) $(strip $(M64)) $(strip $(OMIT_LEAF_FP))
WOPTS := -Wall -Werror=format-security
--
2.51.1
next prev parent reply other threads:[~2025-11-07 16:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 16:17 [PATCH 0/3] Improve Makefile robustness and explicitness Wander Lairson Costa
2025-11-07 16:17 ` Wander Lairson Costa [this message]
2025-11-07 16:17 ` [PATCH 2/3] Makefile: Improve compiler flag detection for -fcf-protection Wander Lairson Costa
2025-11-07 16:41 ` Derek Barbosa
2025-11-07 16:17 ` [PATCH 3/3] Makefile: Explicitly run the 'test' target in the tests directory Wander Lairson Costa
2025-11-11 14:50 ` [PATCH 0/3] Improve Makefile robustness and explicitness Sebastian Andrzej Siewior
2025-11-11 15:35 ` Derek Barbosa
2025-11-11 15:50 ` Sebastian Andrzej Siewior
2025-11-11 16:29 ` Derek Barbosa
2025-11-12 7:41 ` Sebastian Andrzej Siewior
2025-11-12 12:12 ` Wander Lairson Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251107161729.320087-2-wander@redhat.com \
--to=wander@redhat.com \
--cc=debarbos@redhat.com \
--cc=jkacur@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=luochunsheng@ustc.edu \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox