From: John Kacur <jkacur@redhat.com>
To: linux-rt-users <linux-rt-users@vger.kernel.org>
Cc: Clark Williams <williams@redhat.com>, John Kacur <jkacur@redhat.com>
Subject: [PATCH 19/23] tuna: Fix setting a realtime scheduling policy
Date: Fri, 7 Nov 2025 13:57:28 -0500 [thread overview]
Message-ID: <20251107185732.23992-20-jkacur@redhat.com> (raw)
In-Reply-To: <20251107185732.23992-1-jkacur@redhat.com>
According to the tuna documentation if a user specifies a real-time
scheduling policy then the default priority is 1 if not specified.
Fix this in the gui by explicitly setting it to one in
thread_set_attributes
There were also some incorrect debugging messages in
thread_set_attributes because the affinity was sometimes treated as a
list and sometimes treated as a set.
Fix this by converting the results of os.sched_getscheduler(pid) to a
list
Signed-off-by: John Kacur <jkacur@redhat.com>
---
tuna/gui/util.py | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tuna/gui/util.py b/tuna/gui/util.py
index 92bd368179cc..68bd7578f1c8 100644
--- a/tuna/gui/util.py
+++ b/tuna/gui/util.py
@@ -68,6 +68,9 @@ def thread_set_attributes(pid_info, new_policy, new_prio, new_affinity, nr_cpus)
curr_prio = int(pid_info["stat"]["rt_priority"])
if new_policy == os.SCHED_OTHER:
new_prio = 0
+ if new_policy == os.SCHED_FIFO or new_policy == os.SCHED_RR:
+ if not new_prio:
+ new_prio = 1
if curr_policy != new_policy or curr_prio != new_prio:
param = os.sched_param(new_prio)
try:
@@ -82,6 +85,7 @@ def thread_set_attributes(pid_info, new_policy, new_prio, new_affinity, nr_cpus)
dialog.destroy()
return False
+
curr_policy = os.sched_getscheduler(pid)
if curr_policy != new_policy:
print(_("couldn't change pid %(pid)d from %(cpol)s(%(cpri)d) to %(npol)s(%(npri)d)!") % \
@@ -93,7 +97,7 @@ def thread_set_attributes(pid_info, new_policy, new_prio, new_affinity, nr_cpus)
changed = True
try:
- curr_affinity = os.sched_getaffinity(pid)
+ curr_affinity = list(os.sched_getaffinity(pid))
except OSError as err:
if err.args[0] == errno.ESRCH:
return False
@@ -116,7 +120,7 @@ def thread_set_attributes(pid_info, new_policy, new_prio, new_affinity, nr_cpus)
return invalid_affinity()
try:
- curr_affinity = os.sched_getaffinity(pid)
+ curr_affinity = list(os.sched_getaffinity(pid))
except OSError as err:
if err.args[0] == errno.ESRCH:
return False
--
2.51.1
next prev parent reply other threads:[~2025-11-07 18:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 18:57 [ANNOUNCE] tuna v0.20 John Kacur
2025-11-07 18:57 ` [PATCH 01/23] Add SPDX license identifiers John Kacur
2025-12-18 2:45 ` Kate Stewart
2025-11-07 18:57 ` [PATCH 02/23] tuna: Remove spec file from git John Kacur
2025-11-07 18:57 ` [PATCH 03/23] tuna: Don't start the gui if a display is not available John Kacur
2025-11-07 18:57 ` [PATCH 04/23] tuna: Fix string syntax warnings with raw strings John Kacur
2025-11-07 18:57 ` [PATCH 05/23] tuna: Fix help.py syntax warnings John Kacur
2025-11-07 18:57 ` [PATCH 06/23] tuna: help.py John Kacur
2025-11-07 18:57 ` [PATCH 07/23] tuna: extract common cpu and nics determination code into a utils.py file John Kacur
2025-11-07 18:57 ` [PATCH 08/23] tuna: Add idle_state control functionality John Kacur
2025-11-07 18:57 ` [PATCH 09/23] tuna: utils: A few tweaks John Kacur
2025-11-07 18:57 ` [PATCH 10/23] tuna: Add Pyright helper John Kacur
2025-11-07 18:57 ` [PATCH 11/23] tuna: Update man page with cpu_power command John Kacur
2025-11-07 18:57 ` [PATCH 12/23] tuna: Fix show_threads -t and show_irqs -q John Kacur
2025-11-07 18:57 ` [PATCH 13/23] tuna: Fix run command failing to apply BATCH policy John Kacur
2025-11-07 18:57 ` [PATCH 14/23] tuna: Add -U and -K to the move command John Kacur
2025-11-07 18:57 ` [PATCH 15/23] tuna: Add -U and -K to the spread command John Kacur
2025-11-07 18:57 ` [PATCH 16/23] tuna: replace match with if statements John Kacur
2025-11-07 18:57 ` [PATCH 17/23] tuna: Proofreading fixes John Kacur
2025-11-07 18:57 ` [PATCH 18/23] tuna: Remove broken testuna John Kacur
2025-11-07 18:57 ` John Kacur [this message]
2025-11-07 18:57 ` [PATCH 20/23] tuna: Update setup.py with co-author and metadata improvements John Kacur
2025-11-07 18:57 ` [PATCH 21/23] tuna: Add pyproject.toml for modern Python packaging John Kacur
2025-11-07 18:57 ` [PATCH 22/23] tuna: Update version to 0.20 John Kacur
2025-11-07 18:57 ` [PATCH 23/23] tuna: Fix pyproject.toml build issues John Kacur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251107185732.23992-20-jkacur@redhat.com \
--to=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox