public inbox for linux-rt-users@vger.kernel.org
 help / color / mirror / Atom feed
From: Wander Lairson Costa <wander@redhat.com>
To: williams@redhat.com
Cc: linux-rt-users@vger.kernel.org,
	Wander Lairson Costa <wander@redhat.com>,
	Derek Barbosa <debarbos@redhat.com>,
	John Kacur <jkacur@redhat.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	Chunsheng Luo <luochunsheng@ustc.edu>
Subject: [stalld v2 4/6] Makefile: Remove redundant GCC version check
Date: Mon, 10 Nov 2025 10:22:39 -0300	[thread overview]
Message-ID: <20251110132241.43685-5-wander@redhat.com> (raw)
In-Reply-To: <20251110132241.43685-1-wander@redhat.com>

The minimum GCC version check was introduced to handle the `-fcf-protection`
flag, which was not available in older compiler versions. However, a more
robust method that directly tests for compiler support for this flag has
been implemented.

This commit removes the now-redundant GCC version check, simplifying the
Makefile and relying on the more accurate feature detection.

Signed-off-by: Wander Lairson Costa <wander@redhat.com>
Cc: Derek Barbosa <debarbos@redhat.com>
Cc: John Kacur <jkacur@redhat.com>
Cc: Juri Lelli <juri.lelli@redhat.com>
Cc: Chunsheng Luo <luochunsheng@ustc.edu>
---
 Makefile | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/Makefile b/Makefile
index 619413f..ba67698 100644
--- a/Makefile
+++ b/Makefile
@@ -14,11 +14,6 @@ GCC_VER=$(shell gcc --version | grep ^gcc | cut -f 3 -d ' ' | cut -f 1 -d '.')
 endif
 $(info GCC_VER=$(GCC_VER))
 
-# Does the current GCC compiler have fcf-protection and c99+ as default?
-MIN_GCC_VER := 8
-IS_MINVER := $(intcmp $(GCC_VER), $(MIN_GCC_VER), false, true, true)
-$(info IS_MINVER=$(IS_MINVER))
-
 USE_BPF := 1
 MTUNE	:= -mtune=generic
 M64	:= -m64
-- 
2.51.1


  parent reply	other threads:[~2025-11-10 13:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-10 13:22 [stalld v2 0/6] Improve Makefile portability and debugging Wander Lairson Costa
2025-11-10 13:22 ` [stalld v2 1/6] Makefile: Conditionally add -mno-omit-leaf-frame-pointer Wander Lairson Costa
2025-11-10 17:51   ` Clark Williams
2025-11-10 13:22 ` [stalld v2 2/6] Makefile: Improve compiler flag detection for -fcf-protection Wander Lairson Costa
2025-11-10 17:51   ` Clark Williams
2025-11-10 13:22 ` [stalld v2 3/6] Makefile: Explicitly run the 'test' target in the tests directory Wander Lairson Costa
2025-11-10 17:48   ` Clark Williams
2025-11-10 13:22 ` Wander Lairson Costa [this message]
2025-11-10 17:52   ` [stalld v2 4/6] Makefile: Remove redundant GCC version check Clark Williams
2025-11-11  0:30   ` Derek Barbosa
2025-11-10 13:22 ` [stalld v2 5/6] Makefile: Print BPF tool versions for debugging Wander Lairson Costa
2025-11-10 17:50   ` Clark Williams
2025-11-10 13:22 ` [stalld v2 6/6] gitignore: Exclude Serena and Claude Code metadata Wander Lairson Costa
2025-11-10 17:50   ` Clark Williams
2025-11-25 19:58 ` [stalld v2 0/6] Improve Makefile portability and debugging Clark Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251110132241.43685-5-wander@redhat.com \
    --to=wander@redhat.com \
    --cc=debarbos@redhat.com \
    --cc=jkacur@redhat.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=luochunsheng@ustc.edu \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox