From: Wander Lairson Costa <wander@redhat.com>
To: williams@redhat.com, jkacur@redhat.com, luffyluo@tencent.com,
davidlt@rivosinc.com, linux-rt-users@vger.kernel.org
Cc: Wander Lairson Costa <wander@redhat.com>
Subject: [stalld PATCH] Makefile: Remove unnecessary -m64 compiler flag
Date: Fri, 9 Jan 2026 21:41:29 -0300 [thread overview]
Message-ID: <20260110004129.357260-1-wander@redhat.com> (raw)
Remove the M64 variable and all related architecture-specific overrides
from the Makefile. The -m64 flag is unnecessary because GCC defaults to
generating code for the native architecture. On 64-bit systems it
produces 64-bit binaries automatically, and on 32-bit systems the flag
causes build failures.
This change fixes builds on i686 and 32-bit powerpc architectures,
which were broken after commit 5bd4be43bc5b ("Makefile: Remove
redhat-specific checks")removed the RPMCFLAGS conditional that previously
allowed RPM builds to override the internal compiler flags. Rather than
adding M64 overrides for each 32-bit architecture, removing the flag
entirely is the cleaner solution since it provides no benefit on any platform.
Signed-off-by: Wander Lairson Costa <wander@redhat.com>
---
Makefile | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/Makefile b/Makefile
index a7d7875..467fc84 100644
--- a/Makefile
+++ b/Makefile
@@ -16,11 +16,7 @@ $(info GCC_VER=$(GCC_VER))
USE_BPF := 1
MTUNE := -mtune=generic
-M64 := -m64
-ifeq ($(ARCH),aarch64)
-M64 :=
-endif
ifeq ($(ARCH),i686)
USE_BPF := 0
endif
@@ -37,7 +33,6 @@ MTUNE := -mtune=powerpc
endif
ifeq ($(ARCH),riscv64)
FCF_PROTECTION := "-fcf-protection=none"
-M64 :=
MTUNE := -mtune=generic-ooo
endif
@@ -63,7 +58,7 @@ OMIT_LEAF_FP := $(shell echo 'int main(void){return 0;}' | \
-o /dev/null 2>/dev/null && \
echo '-mno-omit-leaf-frame-pointer')
-MOPTS := $(strip $(MTUNE)) $(strip $(M64)) $(strip $(OMIT_LEAF_FP))
+MOPTS := $(strip $(MTUNE)) $(strip $(OMIT_LEAF_FP))
WOPTS := -Wall -Werror=format-security
--
2.52.0
reply other threads:[~2026-01-10 0:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260110004129.357260-1-wander@redhat.com \
--to=wander@redhat.com \
--cc=davidlt@rivosinc.com \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=luffyluo@tencent.com \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox