Re: [PATCH v2] rteval: Fixed hardcoded paths in class TestCpusetManagerCLIIntegration

[John Kacur <jkacur@redhat.com>]

On Wed, 28 Oct 2026 at 14:21:13 -0400, Sana Sharma wrote:
> [PATCH v2] rteval: Fixed hardcoded paths in class TestCpusetManagerCLIIntegration

Thanks for the patch Sana. Good catch dropping the hardcoded
/home/jkacur path - it would only ever have worked on my machine - and
the switch to pathlib matches what we already do in
tests/test_stressng.py. Two small things to fix, then I'll take it.

1. Don't compute the repo root twice.

> +sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
...
> +    srcdir = str(Path(__file__).resolve().parent.parent)

The same str(Path(__file__).resolve().parent.parent) is evaluated once
here and then again as the class attribute. Name it once at module scope
and reuse it:

    SRCDIR = str(Path(__file__).resolve().parent.parent)
    sys.path.insert(0, SRCDIR)

and in the class:

    srcdir = SRCDIR

It needs to stay at module level (not inside the class), because the
sys.path.insert has to run before the top-of-file "from rteval ..."
imports, and the class is not defined yet at that point.

2. Extra space after the comma.

> +            [sys.executable,  f"{self.srcdir}/rteval-cmd",

There are two spaces after "sys.executable," in each of these calls; it
should be one. pylint won't catch this (it dropped its whitespace checks
a few releases ago), but a formatter like ruff or black will flag and fix
it for you automatically, e.g.:

    ruff format tests/test_cpusetmanager.py

With those addressed I'm happy to apply it.

John