From: Rafael Folco <rfolco@redhat.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: williams@redhat.com, jkacur@redhat.com, linux-rt-users@vger.kernel.org
Subject: Re: [PATCH] Change min/max to float numbers
Date: Thu, 6 Feb 2025 12:02:49 -0300 [thread overview]
Message-ID: <2cb9215a-61d8-4b97-af66-6ef4194f3e04@redhat.com> (raw)
In-Reply-To: <20250206120056.oE88fgG6@linutronix.de>
On 06/02/25 09:00, Sebastian Andrzej Siewior wrote:
> On 2025-02-06 06:16:22 [-0300], Rafael Folco wrote:
>> Make min/max consistent with avg by recording the latency samples
>> as float numbers instead of integers.
>
> Why?
- More precise numbers of Max/Min for extreme low latency cases
- Distinguish zero latency in bucket 001 (us)
- Distinguish values from upper/lower boundaries in a bucket
- Clarify confusion on average (round up) vs maximum in the next bucket (casting)
Instead of:
Core: 3 4 5
Counter Freq: 2100 2100 2100 (MHz)
001 (us): 14880514 14880447 14880442
002 (us): 0 0 0
003 (us): 0 0 0
004 (us): 0 0 0
005 (us): 0 0 0 (including overflows)
Minimum: 0 0 0 (us)
Average: 1.000 1.000 1.000 (us)
Maximum: 0 0 0 (us)
Max-Min: 0 0 0 (us)
We'd see:
Core: 3 4 5
Counter Freq: 2100 2100 2100 (MHz)
001 (us): 12578842 12491108 12578752
002 (us): 0 0 0
003 (us): 0 0 0
004 (us): 0 0 0
005 (us): 0 0 0 (including overflows)
Minimum: 0.033 0.035 0.035 (us)
Average: 1.000 1.000 1.000 (us)
Maximum: 0.129 0.153 0.134 (us)
Max-Min: 0.095 0.118 0.099 (us)
>
>> Signed-off-by: Rafael Folco <rfolco@redhat.com>
>
> Sebastian
>
next prev parent reply other threads:[~2025-02-06 15:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 9:16 [PATCH] Change min/max to float numbers Rafael Folco
2025-02-06 12:00 ` Sebastian Andrzej Siewior
2025-02-06 15:02 ` Rafael Folco [this message]
2025-02-06 15:09 ` Sebastian Andrzej Siewior
2025-02-06 15:24 ` Rafael Folco
2025-02-06 15:36 ` Sebastian Andrzej Siewior
2025-02-06 16:22 ` Rafael Folco
2025-02-06 21:23 ` Crystal Wood
2025-02-07 14:20 ` Rafael Folco
2025-02-07 23:23 ` Crystal Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cb9215a-61d8-4b97-af66-6ef4194f3e04@redhat.com \
--to=rfolco@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).