public inbox for linux-rt-users@vger.kernel.org
 help / color / mirror / Atom feed
From: John Kacur <jkacur@redhat.com>
To: Tomas Glozar <tglozar@redhat.com>
Cc: Clark Williams <williams@redhat.com>,
	 Linux RT Users <linux-rt-users@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] rteval: Move unittest.py to tests/
Date: Mon, 10 Nov 2025 14:11:27 -0500 (EST)	[thread overview]
Message-ID: <2eb2aab4-eb87-f88b-e979-9d4cce2465eb@redhat.com> (raw)
In-Reply-To: <20251107134749.257350-2-tglozar@redhat.com>



On Fri, 7 Nov 2025, Tomas Glozar wrote:

> We now have a tests/ folder. Move unittest.py there, and remove folder
> unit-tests.
> 
> Signed-off-by: Tomas Glozar <tglozar@redhat.com>
> ---
>  {unit-tests => tests}/unittest.py | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  rename {unit-tests => tests}/unittest.py (100%)
> 
> diff --git a/unit-tests/unittest.py b/tests/unittest.py
> similarity index 100%
> rename from unit-tests/unittest.py
> rename to tests/unittest.py
> -- 
> 2.51.0

Nack

This one breaks make test.
this type of unittest is not widely used in rteval
and was written before and conflicts with the unittest in
the current python library.

In short, I'm thinking of removing the old unittest and 
might replace it with the built-in version.


  reply	other threads:[~2025-11-10 19:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-07 13:47 [PATCH v2 1/3] rteval: Introduce E2E tests with output checking Tomas Glozar
2025-11-07 13:47 ` [PATCH v2 2/3] rteval: Move unittest.py to tests/ Tomas Glozar
2025-11-10 19:11   ` John Kacur [this message]
2025-11-11  7:52     ` Tomas Glozar
2025-11-07 13:47 ` [PATCH v2 3/3] rteval: Add README-tests Tomas Glozar
2025-11-10 19:12   ` John Kacur
2025-11-11  7:53     ` Tomas Glozar
2025-11-10 19:07 ` [PATCH v2 1/3] rteval: Introduce E2E tests with output checking John Kacur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2eb2aab4-eb87-f88b-e979-9d4cce2465eb@redhat.com \
    --to=jkacur@redhat.com \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=tglozar@redhat.com \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox