From: Crystal Wood <crwood@redhat.com>
To: debarbos@redhat.com
Cc: clrkwllms@kernel.org, linux-rt-users@vger.kernel.org, wander@redhat.com
Subject: Re: [PATCH 2/3] Makefile: Add support for legacy kernels
Date: Thu, 09 Oct 2025 23:07:45 -0500 [thread overview]
Message-ID: <367f7c89f0915f586a133914fe509d2913941cc4.camel@redhat.com> (raw)
In-Reply-To: <xlsdpirj2vodtryotfqn6weo4dly3elwctxs6xcyur2skkmmix@anxl6dmzgig3>
On Wed, 2025-10-08 at 19:52 -0400, Derek Barbosa wrote:
> On Wed, Oct 08, 2025 at 04:38:49PM -0500, Crystal Wood wrote:
> > On Wed, 2025-10-08 at 14:41 -0400, Derek Barbosa wrote:
> >
> > >
> > > Appending c99 to the CFLAGS on the command-line a-la `CFLAGS+=-std=c99`
> > > overrides the cflags entirely... so editing the CFLAGS to append -std=c99..
> >
> > You're saying that if you do CFLAGS+=-std=c99 the only thing in CFLAGS
> > is -std=c99? That shouldn't happen...
>
> Yeah...
>
> ```
> [root@rt-qe-06 stalld]# make USE_BPF=0 SOPTS= FCF_PROTECTION= CFLAGS+=-std=c99
Oh, I missed "on the command-line". If you want to make that work, the
makefile itself would have to use
"override CFLAGS += <the normal stuff>" instead of "CFLAGS :=".
There's nothing to add to yet when processing the command line
variables.
-Crystal
next prev parent reply other threads:[~2025-10-10 4:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-02 20:55 [PATCH 0/3] stalld: Improve legacy kernel support and unify sched_debug parsing Derek Barbosa
2025-10-02 20:55 ` [PATCH 1/3] sched_debug: Unify parsing methods for task_info Derek Barbosa
2025-10-02 20:55 ` [PATCH 2/3] Makefile: Add support for legacy kernels Derek Barbosa
2025-10-07 16:43 ` Clark Williams
2025-10-07 18:50 ` Crystal Wood
2025-10-08 13:07 ` Derek Barbosa
2025-10-08 16:50 ` Crystal Wood
2025-10-08 18:41 ` Derek Barbosa
2025-10-08 21:38 ` Crystal Wood
2025-10-08 23:52 ` Derek Barbosa
2025-10-10 4:07 ` Crystal Wood [this message]
2025-10-17 13:16 ` Clark Williams
2025-10-20 16:54 ` Crystal Wood
2025-10-20 18:18 ` Derek Barbosa
2025-10-17 13:20 ` Clark Williams
[not found] ` <CAMLffL_a2-RkOJg8kXPZSKhzenu9aPDs4SBz-F97y9-wa_oHHQ@mail.gmail.com>
2025-10-20 16:48 ` Crystal Wood
2025-10-21 13:04 ` Clark Williams
2025-10-02 20:55 ` [PATCH 3/3] scripts: fix run-local if bashism Derek Barbosa
2025-10-07 16:42 ` Clark Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=367f7c89f0915f586a133914fe509d2913941cc4.camel@redhat.com \
--to=crwood@redhat.com \
--cc=clrkwllms@kernel.org \
--cc=debarbos@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=wander@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).