From: John Kacur <jkacur@redhat.com>
To: "John B. Wyatt IV" <jwyatt@redhat.com>
Cc: Clark Williams <williams@redhat.com>,
linux-rt-users@vger.kernel.org,
kernel-rts-sst <kernel-rts-sst@redhat.com>,
"John B. Wyatt IV" <sageofredondo@gmail.com>
Subject: Re: [PATCH] tuna: Add common virtual envs gitignores
Date: Thu, 18 Sep 2025 14:06:06 -0400 (EDT) [thread overview]
Message-ID: <3c66730b-a473-f103-bf13-cc19d312880d@redhat.com> (raw)
In-Reply-To: <20250813200839.82200-1-jwyatt@redhat.com>
On Wed, 13 Aug 2025, John B. Wyatt IV wrote:
> Virtual environments are a common method to develop in the Python world.
> The virtual environment directories are ignored.
>
> Copied partially from https://github.com/github/gitignore/blob/main/Python.gitignore
>
> License of copied text: CC0-1.0 (Public Domain declaration)
> https://github.com/github/gitignore/blob/main/LICENSE
>
> Signed-off-by: John B. Wyatt IV <jwyatt@redhat.com>
> Signed-off-by: John B. Wyatt IV <sageofredondo@gmail.com>
> ---
> .gitignore | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index 29b00a0..1fa5bbd 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -2,3 +2,13 @@
> *~
> *.swp
> tags
> +
> +# Environments
> +.env
> +.envrc
> +.venv
> +env/
> +venv/
> +ENV/
> +env.bak/
> +venv.bak/
> --
> 2.50.1
>
>
>
I ran in a python virtual environment and only got an env directory which
I deleted at the end. Are you actually using this, or is this just
theorectically something we might want to add?
Granted, I didn't do anything complicated with this
I also understand you are trying to do your due dilligence by referencing
where you copied this from, but then pulling in another license to do so.
This is going to cause me headaches for something kind of trivial.
I'd rather not have a lot of patches creating churn in something like
.gitignore, if we start using this a lot and it becomes more convenient to
add somethings here, then fine, but then figure it out yourself, and don't
copy from somewhere else. I think we'll just ignore this for now please.
John
next prev parent reply other threads:[~2025-09-18 18:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 20:08 [PATCH] tuna: Add common virtual envs gitignores John B. Wyatt IV
2025-09-18 18:06 ` John Kacur [this message]
2025-09-22 15:50 ` John B. Wyatt IV
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c66730b-a473-f103-bf13-cc19d312880d@redhat.com \
--to=jkacur@redhat.com \
--cc=jwyatt@redhat.com \
--cc=kernel-rts-sst@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=sageofredondo@gmail.com \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).