Re: [PATCH]: Atmel Serial Console interrupt handler splitup

["Remy Bohmer" <linux@bohmer.net>]

Hello Steven,

> > So, I have here 3 patches:
> > * atmel_serial_cleanup -> This patch adapts the driver to the coding
> > rules, splits the interrupt handler into 3 routines (cuts the routine
> > in more readable pieces) , but there is no functional change involved.
> > * atmel_serial_irq_splitup -> This patch splits up the interrupt handler.
> > * atmel_serial_irqf_nodelay -> This patch is additionally required to
> > get it properly working on Preempt-RT. (This patch should thus go into
> > the RT-patch, AFTER integration of the other 2 patches into mainline)
> >
> > BUT: I based the patch on the 2.6.23.1 + Andrews patch collection at
> > http://maxim.org.za/AT91RM9200/2.6/2.6.23-at91.patch.gz
>
> I could pull all the patches into RT (although I would like Thomas to take
> a look first and give an OK).

Instead of pulling the complete patchset, we can also pull the minimal
set of patches to make Preempt-RT to work properly on AT91; Preempt-RT
depends on:
1) ClockSource & ClockEvents for AT91RM9200. [David Brownell, and others]
2) Support configurable HZ. [David Brownell]
3) The Serial port interrupt handler splitup patchset.
4) And of course, the
use-edge-irq-instead-of-simple-irq-interrupt-handler patch for AT91, I
posted last week.

Maybe, Andrew can provide the patches 1 and 2 separate from his
patchset, so you can add them to RT for 2.6.23 only? patch 1 seems to
be in 2.6.24-rc4 already.

> And then apply your patches on top. I'm
> assuming that this only affects the ARM architecture and the AT91 device?

The complete patchset from Andrew also effects other Atmel cores, and
I only focussed on AT91sam/at91rm. Andrew mentioned that the DMA patch
for Serial in his set did not work on AVR32, so, we probably do not
want to have that change until it is really stable.
Tomorrow, I can easily make my set separate from that DMA part, so
that the patches 1-4 can be mainlined without other dependencies,
including the irqf_nodelay-patch which can be put in the RT-patchset.
I can post this mainline-able patch (3) tomorrow.

> I'm leaving this out for -rt13 and for the next cut of 2.6.24-rc-rt. But
> if Thomas is OK with pulling in the external patch queue, I'll do it for
> -rt14.

OK.

> It is best if the patch queue in question makes it into mainline.

Agree.


Kind Regards,

Remy