From: "Gregory Haskins" <ghaskins@novell.com>
To: "Ingo Molnar" <mingo@elte.hu>, "Steven Rostedt" <rostedt@goodmis.org>
Cc: <chinang.ma@intel.com>, <suresh.b.siddha@intel.com>,
<arjan@linux.intel.com>, <willy@linux.intel.com>,
<linux-kernel@vger.kernel.org>, <linux-rt-users@vger.kernel.org>
Subject: Re: [PATCH v2] sched: push rt tasks only if newly activated taskshave been added
Date: Mon, 21 Apr 2008 10:36:20 -0600 [thread overview]
Message-ID: <480C8A44.BA47.005A.0@novell.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0804211224380.18530@gandalf.stny.rr.com>
>>> On Mon, Apr 21, 2008 at 12:25 PM, in message
<Pine.LNX.4.58.0804211224380.18530@gandalf.stny.rr.com>, Steven Rostedt
<rostedt@goodmis.org> wrote:
>
> I'm betting that this needs a CONFIG_SMP around it.
Indeed, thanks! Will send update against sched-devel with this fix.
>
> -- Steve
>
>> inc_cpu_load(rq, p->se.load.weight);
>> }
>>
>> @@ -913,7 +920,7 @@ static int push_rt_task(struct rq *rq)
>> int ret = 0;
>> int paranoid = RT_MAX_TRIES;
>>
>> - if (!rq->rt.overloaded)
>> + if (!rq->rt.overloaded || rq->rt.pushed)
>> return 0;
>>
>> next_task = pick_next_highest_task_rt(rq, -1);
>> @@ -973,6 +980,15 @@ out:
>> }
>>
>> /*
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-04-21 16:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-21 15:42 [PATCH v2] sched: push rt tasks only if newly activated tasks have been added Gregory Haskins
2008-04-21 16:17 ` Ingo Molnar
2008-04-21 16:20 ` Ingo Molnar
2008-04-21 16:25 ` Steven Rostedt
2008-04-21 16:36 ` Gregory Haskins [this message]
2008-04-21 16:34 ` [PATCH v2] sched: push rt tasks only if newly activated taskshave " Gregory Haskins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480C8A44.BA47.005A.0@novell.com \
--to=ghaskins@novell.com \
--cc=arjan@linux.intel.com \
--cc=chinang.ma@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=suresh.b.siddha@intel.com \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).