linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: jvrao <jvrao@linux.vnet.ibm.com>
To: LKML <linux-kernel@vger.kernel.org>,
	rt-users <linux-rt-users@vger.kernel.org>
Cc: Mike Anderson <andmike@linux.vnet.ibm.com>,
	"Luis Claudio R. Goncalves" <lgoncalv@redhat.com>,
	linux-driver@qlogic.com
Subject: Interrupts are being dropped under heavy IO on -rt .
Date: Fri, 10 Apr 2009 09:20:31 -0700	[thread overview]
Message-ID: <49DF71CF.7070509@linux.vnet.ibm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 681 bytes --]

Qlogic driver uses MSI-EDGE interrupts by default.
 
On -rt kernel under heavy IO load we observed that the driver missed 
interrupts occasionally.

Missing interrupts caused spurious mailbox timeouts and path failovers.

Suspecting MSI interrupts, we disabled MSI and forcing the driver to use 
APIC interrupts (Patch attached).

With this change, our IO tests ran for extended period of time without 
any issues.

It would be interesting to see if the MSI infrastructure itself has 
issues on realtime, or it is the combination of qla2xxx/MSI.

Right now we don't have any setup to test out MSI with other adapters. 
Hence, wondering if anyone faced similar issues.

Thanks,
JV


[-- Attachment #2: qla_nomsi.patch --]
[-- Type: text/x-patch, Size: 1203 bytes --]

Index: linux-2.6.29.1/drivers/scsi/qla2xxx/qla_isr.c
===================================================================
--- linux-2.6.29.1.orig/drivers/scsi/qla2xxx/qla_isr.c
+++ linux-2.6.29.1/drivers/scsi/qla2xxx/qla_isr.c
@@ -1983,7 +1983,13 @@ qla2x00_request_irqs(struct qla_hw_data 
 	/* If possible, enable MSI-X. */
 	if (!IS_QLA2432(ha) && !IS_QLA2532(ha) &&
 	    !IS_QLA8432(ha) && !IS_QLA8001(ha))
+#ifdef CONFIG_PREEMPT_RT
+		/* Observed IO timeouts with MSI iterrupts on -rt kernel. */
+		/* This code change forces the driver to use APIC interrupts. */
+		goto skip_msi;
+#else
 		goto skip_msix;
+#endif /* CONFIG_PREEMPT_RT */
 
 	if (IS_QLA2432(ha) && (ha->pdev->revision < QLA_MSIX_CHIP_REV_24XX ||
 		!QLA_MSIX_FW_MODE_1(ha->fw_attributes))) {
Index: linux-2.6.29.1/drivers/scsi/qla2xxx/qla_version.h
===================================================================
--- linux-2.6.29.1.orig/drivers/scsi/qla2xxx/qla_version.h
+++ linux-2.6.29.1/drivers/scsi/qla2xxx/qla_version.h
@@ -7,7 +7,7 @@
 /*
  * Driver version
  */
-#define QLA2XXX_VERSION      "8.03.00-k4"
+#define QLA2XXX_VERSION      "8.03.00-k4-rt1"
 
 #define QLA_DRIVER_MAJOR_VER	8
 #define QLA_DRIVER_MINOR_VER	3

             reply	other threads:[~2009-04-10 16:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-10 16:20 jvrao [this message]
2009-04-10 21:59 ` Interrupts are being dropped under heavy IO on -rt Thomas Gleixner
2009-04-15 19:48 ` Andrew Vasquez
2009-04-23 21:38   ` jvrao
2009-04-27  5:13     ` jvrao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49DF71CF.7070509@linux.vnet.ibm.com \
    --to=jvrao@linux.vnet.ibm.com \
    --cc=andmike@linux.vnet.ibm.com \
    --cc=lgoncalv@redhat.com \
    --cc=linux-driver@qlogic.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).