Re: cyclictest - fix comparison about flexible word counts of available_tracers file.

[GeunSik Lim <leemgs1@gmail.com>]

Dear Clark

Thanks your patching.

Since I didn't have IRQSOFF or
> PREEMPTOFF set in my kernel, those tracers weren't available and fscanf
> never returned EOF (it kept returning the "nop" tracer).

Clark. I think that Your approach is right.

In fact , I also thought  this case that  a developer disable
PREEMPTOFF or IRQSOFF on "#>make menuconfig" setting menu.
As you know, Most peoples will use -P or -I option when they enabled
PREEMPTOFF or IRQSOFF in Linux Kernel just.

But, Exception Handling is important as your explanation.
Thanks again.


2009/4/5 Clark Williams <williams@redhat.com>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Sun, 5 Apr 2009 15:45:33 +0900
> GeunSik Lim <leemgs1@gmail.com> wrote:
>
>> Dear Thomas,
>>
>> I found bug at settracer function of cyclictest.c source (rt-test ver 0.33).
>> settracer func use 10 times in the for() statement to searching tracer
>> like preemptoff , irqsoff , preemptirqsoff.
>> But, I think that we have to consider 10+ words in the available_tracers file.
>>
>
> GeunSik,
>
> Good catch!  I applied your patch, but then found a bug in either
> fscanf or debugfs (probably debugfs). Since I didn't have IRQSOFF or
> PREEMPTOFF set in my kernel, those tracers weren't available and fscanf
> never returned EOF (it kept returning the "nop" tracer). So I reworked
> your patch to read everything in and parse it using strtok(3).
>
> The git tree has been updated and an rt-tests-0.34.tar.gz tarball is
> available at:
>
> http://www.kernel.org/pub/linux//kernel/people/clrkwllms/rt-tests/
>
> Clark
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.10 (GNU/Linux)
>
> iEYEARECAAYFAknYxR4ACgkQHyuj/+TTEp3TNwCbBNrEHMLjPmAS6JciwjyXWqME
> wpcAn3+nUGdOwCJR6sFGfwundPtaITrk
> =dT+3
> -----END PGP SIGNATURE-----
>



-- 
Regards,
GeunSik Lim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html