From: GeunSik Lim <leemgs1@gmail.com>
To: Clark Williams <williams@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>
Cc: rt-users <linux-rt-users@vger.kernel.org>
Subject: cyclictest - duplicate explanation of cyclictest option
Date: Mon, 6 Apr 2009 11:56:46 +0900 [thread overview]
Message-ID: <49b7c2350904051956n214efbb5pc8cd9990820a534f@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2217 bytes --]
Dear Clark,
This is trivial contents about option of cyclictest.
Cyclictest utiltiy (ver 0.34) display the information with duplicate
"-h" options,
when a user run "cyclictest --help" command.
User will confuse exact understanding because of duplicate
description of -h option.
How about you remove "-h H_MAX *****" line?
Thanks reading.
Signed-off-by: GeunSik Lim <leemgs1@gmail.com>
diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
index f878217..cedc36f 100644
--- a/src/cyclictest/cyclictest.c
+++ b/src/cyclictest/cyclictest.c
@@ -688,7 +688,8 @@ static void display_help(void)
"-d DIST --distance=DIST distance of thread
intervals in us default=500\n"
"-E --event event tracing (used with -b)\n"
"-f --ftrace function trace (when -b is active)\n"
- "-h H_MAX latency histogram size in
us default 0 (off)\n"
+ "-h --histogram=US dump a latency histogram to
stdout after the run\n"
+ " US is the max time to be be
tracked in microseconds\n"
"-i INTV --interval=INTV base interval of thread in
us default=1000\n"
"-I --irqsoff Irqsoff tracing (used with -b)\n"
"-l LOOPS --loops=LOOPS number of loops:
default=0(endless)\n"
@@ -710,8 +711,6 @@ static void display_help(void)
"-D --duration=t specify a length for the test run\n"
" default is in seconds, but
'm', 'h', or 'd' maybe added\n"
" to modify value to minutes,
hours or days\n"
- "-h --histogram=US dump a latency histogram to
stdout after the run\n"
- " US is the max time to be be
tracked in microseconds\n"
);
exit(0);
}
--
Regards,
GeunSik Lim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[-- Attachment #2: remove-duplicate-h-option.patch --]
[-- Type: application/octet-stream, Size: 1847 bytes --]
From: GeunSik Lim <leemgs1@gmail.com>
Cyclictest utiltiy display the information with duplicate "-h" options,
when a user run "cyclictest --help" command.
User will confuse exact understanding because of duplicate description of -h option
Signed-off-by: GeunSik Lim <leemgs1@gmail.com>
diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
index f878217..cedc36f 100644
--- a/src/cyclictest/cyclictest.c
+++ b/src/cyclictest/cyclictest.c
@@ -688,7 +688,8 @@ static void display_help(void)
"-d DIST --distance=DIST distance of thread intervals in us default=500\n"
"-E --event event tracing (used with -b)\n"
"-f --ftrace function trace (when -b is active)\n"
- "-h H_MAX latency histogram size in us default 0 (off)\n"
+ "-h --histogram=US dump a latency histogram to stdout after the run\n"
+ " US is the max time to be be tracked in microseconds\n"
"-i INTV --interval=INTV base interval of thread in us default=1000\n"
"-I --irqsoff Irqsoff tracing (used with -b)\n"
"-l LOOPS --loops=LOOPS number of loops: default=0(endless)\n"
@@ -710,8 +711,6 @@ static void display_help(void)
"-D --duration=t specify a length for the test run\n"
" default is in seconds, but 'm', 'h', or 'd' maybe added\n"
" to modify value to minutes, hours or days\n"
- "-h --histogram=US dump a latency histogram to stdout after the run\n"
- " US is the max time to be be tracked in microseconds\n"
);
exit(0);
}
next reply other threads:[~2009-04-06 2:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-06 2:56 GeunSik Lim [this message]
2009-04-06 8:29 ` cyclictest - duplicate explanation of cyclictest option GeunSik Lim
2009-04-06 23:15 ` GeunSik Lim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49b7c2350904051956n214efbb5pc8cd9990820a534f@mail.gmail.com \
--to=leemgs1@gmail.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).