From: GeunSik Lim <leemgs1@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: trem <tremyfr@yahoo.fr>, linux-rt-users@vger.kernel.org
Subject: Re: [PATCH] fix argument -C on cyclictest
Date: Mon, 20 Apr 2009 23:14:27 +0900 [thread overview]
Message-ID: <49b7c2350904200714y30776380w9c6999e0e7822c88@mail.gmail.com> (raw)
In-Reply-To: <20090419175218.GA22205@pengutronix.de>
Hi Uwe Kleine-Konig
I already submited same issues. for example, --context and --event.
Is your patch proposal is different?
Refer to http://marc.info/?l=linux-rt-users&m=123919858213957&w=2 webpage.
Regards,
GeunSik Lim.
2009/4/20 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
> Hi,
>
> On Sun, Apr 19, 2009 at 05:09:25PM +0200, trem wrote:
>> The argument -C isn't used in cyclictest, only --context is recognized.
>>
>> Signed-off-by: trem <trem@mandriva.org>
>> ---
>> diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
>> index f878217..e67d0d3 100644
>> --- a/src/cyclictest/cyclictest.c
>> +++ b/src/cyclictest/cyclictest.c
>> @@ -777,7 +777,7 @@ static void process_options (int argc, char *argv[])
>> {"help", no_argument, NULL, '?'},
>> {NULL, 0, NULL, 0}
>> };
>> - int c = getopt_long (argc, argv, "a::b:Bc:d:fh:i:Il:nNo:p:Pmqrst::vD:",
>> + int c = getopt_long (argc, argv, "a::b:Bc:Cd:fh:i:Il:nNo:p:Pmqrst::vD:",
>> long_options, &option_index);
> After the commit log I would have expected that you remove C from the
> options list. I would suggest something like "make cyclictest accept -C
> as documented. This is the same as --context".
>
> BTW, I just noticed that both -C and --context don't appear in the man
> page.
>
> Best regards
> Uwe
>
> --
> Pengutronix e.K. | Uwe Kleine-König |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Regards,
GeunSik Lim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-04-20 14:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-19 15:09 [PATCH] fix argument -C on cyclictest trem
2009-04-19 17:52 ` Uwe Kleine-König
2009-04-20 14:14 ` GeunSik Lim [this message]
2009-04-20 19:16 ` Clark Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49b7c2350904200714y30776380w9c6999e0e7822c88@mail.gmail.com \
--to=leemgs1@gmail.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=tremyfr@yahoo.fr \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).