From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: x86: Kick VCPU outside PIC lock again Date: Wed, 24 Feb 2010 12:17:31 +0200 Message-ID: <4B84FCBB.8070702@redhat.com> References: <20100217135901.331576359@linutronix.de> <4B842A1F.50601@siemens.com> <4B84F466.2080009@siemens.com> <4B84F5D4.5020202@redhat.com> <4B84F765.5040209@siemens.com> <4B84F9AF.8060804@redhat.com> <4B84FBDB.1070006@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Thomas Gleixner , KVM , Gleb Natapov , RT , Linux Kernel Mailing List To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:33502 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755927Ab0BXKRj (ORCPT ); Wed, 24 Feb 2010 05:17:39 -0500 In-Reply-To: <4B84FBDB.1070006@siemens.com> Sender: linux-rt-users-owner@vger.kernel.org List-ID: On 02/24/2010 12:13 PM, Jan Kiszka wrote: > > >> I see. Won't we hit the same issue when we call pic functions from >> atomic context during the guest entry sequence? >> >> > If there are such call paths, for sure. What concrete path(s) do you > have in mind? > > vcpu_enter_guest() -> inject_pending_event() -> kvm_cpu_{has,get}_interrupt() -> various pic functions if you're unlucky. -- error compiling committee.c: too many arguments to function