linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Carsten Emde <Carsten.Emde@osadl.org>
To: John Kacur <jkacur@redhat.com>
Cc: Clark Williams <williams@redhat.com>,
	rt-users <linux-rt-users@vger.kernel.org>
Subject: Re: [PATCH] cyclictest: Use symbolic names for scheduling policy
Date: Mon, 08 Mar 2010 14:01:08 +0100	[thread overview]
Message-ID: <4B94F514.5090605@osadl.org> (raw)
In-Reply-To: <520f0cf11003080448o64b6f8b1nd43be217dcc8fcad@mail.gmail.com>

Hi John,

>> [..]
>> We need to adapt the help message accordingly.
> Hmnn, not sure if I like this one. The message is not perfect as it
> stands, but I don't think this is an improvement.
> The code seems to parse, fifo, rr, and other.
> Internally the numbers are as specified, but we're not parsing them anyway.
The original help message says:

-y POLI  --policy=POLI     policy of realtime thread (1:FIFO, 2:RR)
                           format: --policy=fifo(default) or --policy=rr

This *could* be understood that "-y 2" would be a legal way to specify
SCHED_RR, but it is not. Shouldn't we at least remove the "(1:FIFO,
2:RR)" part?

	Carsten.

  reply	other threads:[~2010-03-08 13:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-08  1:18 [PATCH] Fix scheduling policy problems for cyclictest John Kacur
2010-03-08  1:18 ` [PATCH] Revert "simplify equal priority logic for cyclictest" John Kacur
2010-03-08  8:01   ` Carsten Emde
2010-03-08  1:18 ` [PATCH] cyclictest: Use symbolic names for scheduling policy John Kacur
2010-03-08  8:35   ` Carsten Emde
2010-03-08 12:48     ` John Kacur
2010-03-08 13:01       ` Carsten Emde [this message]
2010-03-08 13:11         ` John Kacur
2010-03-08  1:18 ` [PATCH] cyclictest: Fix spelling mistake in the man page John Kacur
2010-03-08  1:18 ` [PATCH] cyclictest: Make the default scheduling policy SCHED_FIFO John Kacur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B94F514.5090605@osadl.org \
    --to=carsten.emde@osadl.org \
    --cc=jkacur@redhat.com \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).