linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Carsten Emde <Carsten.Emde@osadl.org>
To: John Kacur <jkacur@redhat.com>
Cc: David Sommerseth <davids@redhat.com>,
	RT-users <linux-rt-users@vger.kernel.org>
Subject: Re: [PATCH 2/2] add-smp-option-to-svsematest.patch
Date: Tue, 09 Mar 2010 22:07:27 +0100	[thread overview]
Message-ID: <4B96B88F.8050709@osadl.org> (raw)
In-Reply-To: <520f0cf11003091015i4c474939i8086cdd2bf98a438@mail.gmail.com>

John,

>>> -             if (priority > 0)
>>> +             if (priority > 1 && !sameprio)
>>>                       priority--;
>> Unless I'm missing something really obvious, shouldn't this one state:
>>        if (priority > 0 && !sameprio)
>>                priority--;
>> Or else 1 will be the lowest priority.  It's a similar situation in
>> "[PATCH 1/2] add-smp-option-to-ptsematest.patch" as well.
> Carsten, is it useful to have SCHED_OTHER for this test?
Don't think so. These tests (svsematest, ptsematest etc.) are intended
as additional tests to cyclictest. I used them to make sure that the
implementations of the various semaphore mechanisms (that mostly boil
down to the same kernel code) do not introduce additional latencies. It
may be sufficient to have cyclictest equipped with the numerous (and
exotic) options.

Another plan was to add a plugin slot to cyclictest, since probably more
than 90% of the code of the various test programs is identical. A plugin
version of cyclictest would provide all the various runtime and
scheduler options, the stop clocks and the test framework. The actual
test plugin could be specified as a command line argument. The plugin
interface would need to connect the start and stop code of a particular
test to cyclictest. But this was just a plan...

	Carsten.



  reply	other threads:[~2010-03-09 21:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-07 20:48 [PATCH 0/2] [rt-tests] Add smp option to ptsematest and svsematest Carsten Emde
2010-03-07 20:48 ` [PATCH 1/2] add-smp-option-to-ptsematest.patch Carsten Emde
2010-03-08 12:45   ` John Kacur
2010-03-07 20:48 ` [PATCH 2/2] add-smp-option-to-svsematest.patch Carsten Emde
2010-03-08 12:45   ` John Kacur
2010-03-09 18:10   ` David Sommerseth
2010-03-09 18:15     ` John Kacur
2010-03-09 21:07       ` Carsten Emde [this message]
2010-03-09 20:39     ` Carsten Emde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B96B88F.8050709@osadl.org \
    --to=carsten.emde@osadl.org \
    --cc=davids@redhat.com \
    --cc=jkacur@redhat.com \
    --cc=linux-rt-users@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).