From: Frank Rowand <frank.rowand@am.sony.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: "Rowand, Frank" <Frank_Rowand@sonyusa.com>,
"linux-rt-users@vger.kernel.org" <linux-rt-users@vger.kernel.org>
Subject: Re: Linearized 2.6.33.7-rt30 patch set available (with free coffee!)
Date: Mon, 31 Jan 2011 17:07:14 -0800 [thread overview]
Message-ID: <4D475CC2.5080302@am.sony.com> (raw)
In-Reply-To: <4D474736.40703@windriver.com>
On 01/31/11 15:35, Paul Gortmaker wrote:
> On 11-01-31 04:57 PM, Frank Rowand wrote:
>> On 01/31/11 13:12, Paul Gortmaker wrote:
>>> On 11-01-31 04:05 PM, Frank Rowand wrote:
>>>> Hi Paul,
>>>>
>>>> Thanks for the patch set! I had started down the path of doing
>>>> the same work, and truly appreciate the effort you put into this.
>>>>
>>>> One of the patches had a chunk that failed to apply:
>>>>
>>>> genirq-support-forced-threading-of-interrupts.patch
>>>
>>> Interesting. I was using "git am" to apply them, and I can assure
>>> you that they all applied with that (which is quite strict in its
>>> checking.)
>>>
>>> What were you applying them with?
>>
>> quilt push -a
>
> OK, so it is simply a matter of quilt dying while git am is capable
> of doing the right thing (see below for evidence). I'll re-export all
> the patches on the v2.6.33-rt branch, which will fix you up. Should
> be able to do that shortly -- check the gitweb page for activity on
> the v2.6.33-rt branch, which is what you want to use.
I'll watch for that and check it again.
>
> You do realize that by using quilt though, that you are throwing away
> all the commit headers and the history, which is the whole point of
> this tree existing?
Yes. I do find great value in the history -- it is very informative.
> You are just building up the original RT giant
> diff one chunk at a time. Unless you are thinking or intending to
> insert some other SCM into the quilt processing at each step, I don't
> see the point of using quilt and doing a "push -a"
I wasn't to the point yet of importing the patches into an SCM. I was
just checking that the patches applied and that they are equivalent to
the patch set you started with. Think of it as a simple consistency and
paranoia check that a reviewer would do.
I used quilt because it is a trivial manual method of applying all the
patches, since they are nicely listed in the proper order in the series
file.
-Frank
next prev parent reply other threads:[~2011-02-01 1:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 21:05 Linearized 2.6.33.7-rt30 patch set available (with free coffee!) Frank Rowand
2011-01-31 21:12 ` Paul Gortmaker
2011-01-31 21:57 ` Frank Rowand
2011-01-31 23:35 ` Paul Gortmaker
2011-02-01 1:07 ` Frank Rowand [this message]
2011-02-01 2:15 ` Frank Rowand
-- strict thread matches above, loose matches on Subject: below --
2011-01-24 17:00 Paul Gortmaker
2011-01-24 17:21 ` Madovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D475CC2.5080302@am.sony.com \
--to=frank.rowand@am.sony.com \
--cc=Frank_Rowand@sonyusa.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).