linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@linux.intel.com>
To: John Kacur <jkacur@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	linux-rt-users@vger.kernel.org,
	Clark Williams <williams@redhat.com>
Subject: Re: [PATCH 2/3] rt-tests: Silence unused-but-set warning in rt-migrate-test
Date: Wed, 21 Mar 2012 09:45:14 -0700	[thread overview]
Message-ID: <4F6A059A.2010701@linux.intel.com> (raw)
In-Reply-To: <CAONaPpH3VoiMw5tWFXu1nNDKMJu6AcWJDsoi5Bt2FdS145TC+Q@mail.gmail.com>



On 03/21/2012 09:41 AM, John Kacur wrote:
> On Wed, Mar 21, 2012 at 5:36 PM, Darren Hart <dvhart@linux.intel.com> wrote:
>>
>>
>> On 03/21/2012 09:18 AM, Steven Rostedt wrote:
>>> On Wed, 2012-03-21 at 15:56 +0100, John Kacur wrote:
>>>>>
>>>>
>>>> Yup, shows up on my F16 machine too, with a slightly different gcc version.
>>>> gcc --version
>>>> gcc (GCC) 4.6.2 20111027 (Red Hat 4.6.2-1)
>>>
>>> Egad! This is an old version. It still uses *gasp* logdev!
>>>
>>> I have a new version that writes into ftrace, and doesn't use #ifdef,
>>> but instead just looks to see if it is added to the kernel or not.
>>>
>>> So no, this patch isn't the fix. The real fix is to upgrade to the new
>>> version of the code.
>>>
>>
>> Of the compiler you mean?
>>
> 
> :) Yup, that's what he meant. Of course this is not a realistic option
> for many of us. Can you live with the stupid warning for now instead
> of cluttering the code with the annotations?

Of course, provided this is indeed a gcc bug. I understand we should use
attributes like this very sparingly and I relunctantly sent the patch
thinking it was reasonable for gcc to miss the usage as it gets rolled
into va_list.

Is this resolved in a later version of gcc? Rostedt you apparently use a
newer compiler, can you try a build?

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

  reply	other threads:[~2012-03-21 16:46 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-20 19:05 [PATCH 1/3] rt-tests: Support user supplied CFLAGS and LDFLAGS Darren Hart
2012-03-20 19:05 ` [PATCH 2/3] rt-tests: Silence unused-but-set warning in rt-migrate-test Darren Hart
2012-03-21 14:05   ` Steven Rostedt
2012-03-21 14:44     ` Darren Hart
2012-03-21 14:56       ` John Kacur
2012-03-21 16:18         ` Steven Rostedt
2012-03-21 16:36           ` Darren Hart
2012-03-21 16:41             ` John Kacur
2012-03-21 16:45               ` Darren Hart [this message]
2012-03-21 16:51               ` Steven Rostedt
2012-03-21 16:45             ` Steven Rostedt
2012-03-21 17:11           ` Steven Rostedt
2012-03-21 17:46             ` John Kacur
2012-03-20 19:05 ` [PATCH 3/3] rt-tests: Remove unused status variable Darren Hart
2012-03-21 13:35   ` John Kacur
2012-03-21 14:45     ` Darren Hart
2012-03-20 19:31 ` [PATCH 1/3] rt-tests: Support user supplied CFLAGS and LDFLAGS Remy Bohmer
2012-03-20 19:45   ` Darren Hart
2012-03-20 19:57     ` Remy Bohmer
2012-03-20 23:58 ` John Kacur
2012-03-21  0:10   ` Darren Hart
2012-03-21 19:10     ` Denys Dmytriyenko
2012-03-21 19:11       ` Darren Hart
2012-03-21 20:16         ` John Kacur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F6A059A.2010701@linux.intel.com \
    --to=dvhart@linux.intel.com \
    --cc=jkacur@redhat.com \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).