Re: [PATCH 3/4] rt-tests: cyclictest avoid unneeded warning

[Darren Hart <dvhart@linux.intel.com>]

On 05/01/2012 07:45 PM, Frank Rowand wrote:
> Avoid annoying warning message when tracing is not requested and the debug
> file system is not available. 
> 
> The same test already protects against calling event_enable_all().
> 
> Signed-off-by: Frank Rowand <frank.rowand@am.sony.com>

Cross-compile tested for ARM. Visually inspected, looks sane.

Reviewed-by: Darren Hart <dvhart@linux.intel.com>

> ---
>  src/cyclictest/cyclictest.c |    5 	3 +	2 -	0 !
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> Index: b/src/cyclictest/cyclictest.c
> ===================================================================
> --- a/src/cyclictest/cyclictest.c
> +++ b/src/cyclictest/cyclictest.c
> @@ -1605,8 +1605,9 @@ int main(int argc, char **argv)
>  	if (trace_fd >= 0)
>  		close(trace_fd);
>  
> -	/* turn off all events */
> -	event_disable_all();
> +	if (enable_events)
> +		/* turn off all events */
> +		event_disable_all();
>  
>  	/* turn off the function tracer */
>  	fileprefix = procfileprefix;
> 

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel