From mboxrd@z Thu Jan  1 00:00:00 1970
From: Frank Rowand <frank.rowand@am.sony.com>
Subject: Re: [PATCH RT 2/2] fix printk flush of messages
Date: Mon, 21 May 2012 13:59:24 -0700
Message-ID: <4FBAACAC.3080300@am.sony.com>
References: <4FB44EF1.9050809@am.sony.com> <4FB44FD0.4090800@am.sony.com> <4FBAA150.6050308@caviumnetworks.com>
Reply-To: <frank.rowand@am.sony.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Cc: "Rowand, Frank" <Frank_Rowand@sonyusa.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-rt-users@vger.kernel.org" <linux-rt-users@vger.kernel.org>
To: Venkat Subbiah <vsubbiah@caviumnetworks.com>
Return-path: <linux-rt-users-owner@vger.kernel.org>
Received: from tx2ehsobe005.messaging.microsoft.com ([65.55.88.15]:58185 "EHLO
	tx2outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1758513Ab2EUU7v (ORCPT
	<rfc822;linux-rt-users@vger.kernel.org>);
	Mon, 21 May 2012 16:59:51 -0400
In-Reply-To: <4FBAA150.6050308@caviumnetworks.com>
Sender: linux-rt-users-owner@vger.kernel.org
List-ID: <linux-rt-users.vger.kernel.org>

On 05/21/12 13:10, Venkat Subbiah wrote:
> On 05/16/2012 06:09 PM, Frank Rowand wrote:
>> Updates console-make-rt-friendly.patch
>>
>> #ifdef CONFIG_PREEMPT_RT_FULL, printk() output is never flushed by
>> printk() because:
> So this is an issue for printk() itself and is not just for early_printk()?
> 
> 
>     # some liberties taken in this pseudo-code to make it easier to follow
>     printk()
>        vprintk()
>           raw_spin_lock(&logbuf_lock)
>              # increment preempt_count():
>              preempt_disable()
>        result = console_trylock_for_printk()
> 
> As I read it console_trylock_for_printk() is called from printk() but in 
> code it is called from vprintk()

Yes, I goofed on the indentation, starting at console_trylock_for_printk().
It should have been:

   # some liberties taken in this pseudo-code to make it easier to follow
   printk()
      vprintk()
         raw_spin_lock(&logbuf_lock)
            # increment preempt_count():
            preempt_disable()
         result = console_trylock_for_printk()
            retval = 0
            # lock will always be false, because preempt_count() will be >= 1
            lock = ... && !preempt_count()
            if (lock)
               retval = 1
            return retval
         # result will always be false since lock will always be false
         if (result)
            console_unlock()
               # this is where the printk() output would be flushed

Thanks,

Frank