Re: [PATCH RT-TESTS] cyclictest: new command line switch for histogram overflow instance tracking

[Frank Rowand <frank.rowand@am.sony.com>]

On 11/15/12 17:56, Bhavesh Davda wrote:
> From: Bhavesh Davda <bhavesh@vmware.com>
> 
> Add a new command line option '-g' (long option '--of_max') to cap
> how many outliers are tracked per thread.

< snip >

> ---
> 
>> | Add a line to the histogram overflow cycle report that merges
>> all | threads into a single time line.  This is controlled by the
>> -H | option which already serves a similar purpose for histograms.
>> 
>> The merged data line is an enhancement.  If there is no strong 
>> request from anyone for the feature then no need to include.  But
>> it seems useful to me.
> 
> I agree this is a useful feature request, but harder to implement,
> since I'll have to merge sort from the per-thread outliers to produce
> a single line merged outlier output. I hope it's okay if I punt on
> this one.

It is ok to punt.  But the code to do it was in my patch if you want it.
It is the block of code inside of "if (histofall && nthreads > 1) { ... }".
The code is a little bit ugly, but not totally terrible.

< snip >

I'll look over and test the rest of the patch in a moment (well
actually the next version, which you already sent), as soon
as I finish debugging an email problem.

-Frank