From: Frank Rowand <frank.rowand@am.sony.com>
To: Bhavesh Davda <bhavesh@vmware.com>
Cc: John Kacur <jkacur@redhat.com>,
"linux-rt-users@vger.kernel.org" <linux-rt-users@vger.kernel.org>
Subject: Re: [PATCH RT-TESTS] cyclictest: new command line switch for histogram overflow instance tracking
Date: Mon, 17 Dec 2012 13:34:20 -0800 [thread overview]
Message-ID: <50CF8FDC.3090307@am.sony.com> (raw)
In-Reply-To: <1021286613.24677841.1355768653269.JavaMail.root@vmware.com>
On 12/17/12 10:24, Bhavesh Davda wrote:
>>> I'm going to respond to your proposed patch next.
>>>
>>> Thanks
>>>
>>> - Bhavesh
>>
>> ping....
>>
>> Thanks,
>>
>> Frank
>
> Hello Frank,
>
> Extremely sorry about the tardiness in reviewing your proposed
> change!
No problem. Life is busy, we progress as we can.
> Your change looks good to me. Again, did you want me to fold your
> proposed change into my original patch, or were you proposing
> applying your patch (of course without the #if 0's) on top of mine?
It would be great if you could add my changes on top of your original patch
since John hasn't committed your original patch yet. That way everything
will be coordinated from one person. And yes, without the "#if 0's".
It would probably be good to submit it to John as a series of two patches,
your original patch, followed by my additions.
For my patch, you can add: Signed-off-by: Frank Rowand <frank.rowand@am.sony.com>
My patch did not address one other comment I made, which is:
default of -g to zero means histogram overflows will be printed even
if "-g" not specified (same as "-g 0"). The output of histogram
overflows should only occur if of_max > 0.
> Thanks for spending so much time reviewing my patches, trying them
> out, and suggesting ways to make it better!
Your welcome!
-Frank
next prev parent reply other threads:[~2012-12-17 21:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <943398371.54180912.1352931103535.JavaMail.root@vmware.com>
2012-11-14 22:18 ` [PATCH RT-TESTS] cyclictest: new command line switch for histogram overflow instance tracking Bhavesh Davda
2012-11-14 23:42 ` Frank Rowand
2012-11-15 2:17 ` Bhavesh Davda
2012-11-16 0:11 ` Frank Rowand
2012-11-16 1:56 ` Bhavesh Davda
2012-11-16 2:04 ` Bhavesh Davda
2012-11-16 2:24 ` Frank Rowand
[not found] ` <50A6F713.7010806@am.sony.com>
2012-11-17 2:41 ` Frank Rowand
2012-11-26 21:14 ` Frank Rowand
2012-11-26 21:37 ` Bhavesh Davda
2012-11-29 17:28 ` Bhavesh Davda
2012-11-29 19:57 ` Frank Rowand
2012-12-12 1:45 ` Frank Rowand
2012-12-17 18:24 ` Bhavesh Davda
2012-12-17 21:34 ` Frank Rowand [this message]
2012-12-17 22:17 ` Bhavesh Davda
2012-12-17 23:30 ` Frank Rowand
2012-11-17 2:01 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CF8FDC.3090307@am.sony.com \
--to=frank.rowand@am.sony.com \
--cc=bhavesh@vmware.com \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).