From: Libo Chen <chenlibo.3@gmail.com>
To: Sven-Thorsten Dietrich <sven@thebigcorporation.com>
Cc: linux-rt-users@vger.kernel.org, lizefan@huawei.com,
jovi.zhangwei@huawei.com, libo.chen@huawei.com
Subject: Re: [PATCH] drivers: tty: Make RT aware
Date: Thu, 24 Jan 2013 15:44:36 +0800 [thread overview]
Message-ID: <5100E664.8030504@gmail.com> (raw)
In-Reply-To: <E7D257C8-F848-43D3-A172-8BED9BB400A9@thebigcorporation.com>
On 2013-1-24 13:30, Sven-Thorsten Dietrich wrote:
> On Jan 23, 2013, at 8:07 PM, Libo Chen <chenlibo.3@gmail.com> wrote:
>
>> From: Libo Chen <libo.chen@huawei.com>
>>
>> On RT spinlocks are converted to "sleeping" locks and
>> therefor the local_irq_save/restore must be converted to
>> local_irq_save/restore_nort
>>
>> Signed-off-by: Libo Chen <libo.chen@huawei.com>
>>
>> ---
>> arch/alpha/kernel/srmcons.c | 4 ++--
>> drivers/tty/serial/amba-pl011.c | 4 ++--
>> drivers/tty/serial/ar933x_uart.c | 4 ++--
>> drivers/tty/serial/bcm63xx_uart.c | 4 ++--
>> drivers/tty/serial/mfd.c | 4 ++--
>> drivers/tty/serial/sunhv.c | 8 ++++----
>> drivers/tty/serial/sunsab.c | 4 ++--
>> drivers/tty/serial/sunzilog.c | 4 ++--
>> 8 files changed, 18 insertions(+), 18 deletions(-)
>>
> Has any of this code been tested on actual hardware running RT Kernel?
>
> Thanks
>
> Sven
>
>
Thank you for your attention.
I don`t have these hardwares, and just review the RT code. As we know interrupt
was threaded and spinlock can sleep on RT, so local_irq_save is unnecessary here.
prev parent reply other threads:[~2013-01-24 7:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 4:07 [PATCH] drivers: tty: Make RT aware Libo Chen
2013-01-24 5:30 ` Sven-Thorsten Dietrich
2013-01-24 7:44 ` Libo Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5100E664.8030504@gmail.com \
--to=chenlibo.3@gmail.com \
--cc=jovi.zhangwei@huawei.com \
--cc=libo.chen@huawei.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=sven@thebigcorporation.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).