Build failure. Typo in the 3.2.43-rt63 patch?

Build failure. Typo in the 3.2.43-rt63 patch?

[Dmitry Lysenko]

Hi,

After applying rt63 patch to fresh 3.2.43 I got:
....
   CC      kernel/rcutiny.o
In file included from kernel/rcutiny.c:54:0:
kernel/rcutiny_plugin.h: In function 'invoke_rcu_callbacks':
kernel/rcutiny_plugin.h:886:2: error: implicit declaration of function 
'swake_up' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[2]: *** [kernel/rcutiny.o] Error 1
make[1]: *** [kernel] Error 2
make[1]: Leaving directory `/root/linux-3.2.43'
make: *** [debian/stamp/build/kernel] Error 2
--------

Then I tried this:

-------
root@debian:~/linux-3.2.43# grep -R swake_up
kernel/rcutiny_plugin.h:    swake_up(&rcu_kthread_wq);
patch-3.2.43-rt63.patch:+    swake_up(&rcu_kthread_wq);
root@debian:~/linux-3.2.43#
-------

Finally I manualy changed swake_up to swait_wake in rcutiny_plugin.h 
(line 886).
(don't know is it right), but kernel is builded now.

Dmitry.

P.S. Marvell Kirkwood  native build.

Re: Build failure. Typo in the 3.2.43-rt63 patch?

[Steven Rostedt]

On Sat, 2013-04-20 at 12:09 +0300, Dmitry Lysenko wrote:
> Hi,

> Finally I manualy changed swake_up to swait_wake in rcutiny_plugin.h 
> (line 886).
> (don't know is it right), but kernel is builded now.
> 

That looks correct. I'll add that to the next release.

Thanks,

-- Steve