From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
RT <linux-rt-users@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Clark Williams <clark@redhat.com>, John Kacur <jkacur@redhat.com>,
Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Ingo Molnar <mingo@kernel.org>,
"H. Peter Anvin" <hpa@linux.intel.com>
Subject: Re: [PATCH RT v2] x86/mce: Defer mce wakeups to threads for PREEMPT_RT
Date: Fri, 03 May 2013 11:31:39 +0200 [thread overview]
Message-ID: <518383FB.8020004@linutronix.de> (raw)
In-Reply-To: <1367505199.30667.132.camel@gandalf.local.home>
On 05/02/2013 04:33 PM, Steven Rostedt wrote:
>> mce_notify_irq() can use simple_waitqueue, no?
>
> Yeah, and I went down that path.
>
> But it also schedules work, which has the issue.
Hmm, okay.
>> The other issue is that mce_report_event() is scheduling a per-cpu
>> workqueue (mce_schedule_work) in case of a memory fault. This has the
>> same issue.
>
> Yeah, that looks like it can be an issue too. I wonder if we can use the
> same thread and use flags check what to do. Atomically set the flag for
> the function to perform, and then have the thread clear it before doing
> the function and only go to sleep when all flags are cleared.
This should work. It uses per-cpu workthreads, not sure why. Maybe to
avoid locking issues when invoked from NMI.
>
> -- Steve
Sebastian
prev parent reply other threads:[~2013-05-03 9:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 18:33 [PATCH RT v2] x86/mce: Defer mce wakeups to threads for PREEMPT_RT Steven Rostedt
2013-04-12 13:31 ` Borislav Petkov
2013-04-12 13:42 ` Steven Rostedt
2013-04-12 21:44 ` Luck, Tony
2013-04-12 13:38 ` Borislav Petkov
2013-04-12 13:44 ` Steven Rostedt
2013-04-25 16:44 ` Sebastian Andrzej Siewior
2013-04-25 17:09 ` Steven Rostedt
2013-04-26 8:22 ` Sebastian Andrzej Siewior
2013-04-26 8:24 ` Sebastian Andrzej Siewior
2013-05-02 14:26 ` Steven Rostedt
2013-04-26 8:41 ` Sebastian Andrzej Siewior
2013-05-02 14:33 ` Steven Rostedt
2013-05-03 9:31 ` Sebastian Andrzej Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518383FB.8020004@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=clark@redhat.com \
--cc=hpa@linux.intel.com \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).